Skip to content
This repository

Migrations rewritten #1434

Merged
merged 5 commits into from over 1 year ago

5 participants

Iacopo Spalletti Jonas Obrist Andrew Godwin Patrick Lauber Benjamin Wohlwend
Iacopo Spalletti
Collaborator

All migrations have been created from scratch using South==0.7.5 and saved as 0001_initial; others are empty just to keep migration history consistent. Thanks @Bouke for suggesting this approach.
This is just a first tentative.

Needs docs (pre 2.3.2 installation needs first to install and upgrade to 2.3.2 and then upgrade to this versione) and tests (automated syncdb / migrate on at least sqlite/pgsql/mysql as suggested by @digi604).

Tested on a sample project both with and without CMS_MODERATOR on

Fixes #1427, but many other opened issues are related to migrations/south: maybe they should be referenced here to address those cases in this PR.

Migration related issues:

Iacopo Spalletti Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
ffa11f1
Jonas Obrist
Collaborator

I think we should ask @andrewgodwin what he thinks about this approach. (Please apologize my rude pinging Andrew)

Andrew Godwin

Looks alright to me - provided you make sure everyone has migrated to the most recent migrations in all apps before they pull these changes.

Patrick Lauber
Owner

Still missing:

Iacopo Spalletti
Collaborator

Yes sorry, currently quite busy.
I can work on it next week

Patrick Lauber
Owner

Referencing some tickets: #1032

Patrick Lauber
Owner

any updates here?

and others added some commits
Benjamin Wohlwend Merge pull request #1474 from ojii/simple-plugins
Saner defaults for plugins
f2f44b0
Iacopo Spalletti Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
7091131
Iacopo Spalletti Documentation for new migrations e35d6f8
Iacopo Spalletti
Collaborator

I'm having some issues with multi-db tests.
There are many failing tests on postgres and mysql, some fails as they assume sqlite (e.g. query-counting test); fails differ from postgres to mysql.
Tests fail porting multi-db tests on current develop or using SOUTH_TESTS_MIGRATE = False , so it's not migrations related.
I'd skip multi-db in this PR, and create a new one to work on it separately

Patrick Lauber
Owner

ok

Iacopo Spalletti Merge branch 'feature/migrations_history_rewrite' of github.com:yakky…
…/django-cms into feature/migrations_history_rewrite
8a5b4a8
Iacopo Spalletti
Collaborator

Pushed documentation changes,
Upmf, don't know why github took piquadrat commit too

Patrick Lauber digi604 merged commit 2b95e08 into from
Patrick Lauber digi604 closed this
Iacopo Spalletti
Collaborator

Created new PR for multi-db testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 5 unique commits by 2 authors.

Sep 19, 2012
Iacopo Spalletti Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
ffa11f1
Oct 11, 2012
Benjamin Wohlwend Merge pull request #1474 from ojii/simple-plugins
Saner defaults for plugins
f2f44b0
Oct 12, 2012
Iacopo Spalletti Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
7091131
Iacopo Spalletti Documentation for new migrations e35d6f8
Iacopo Spalletti Merge branch 'feature/migrations_history_rewrite' of github.com:yakky…
…/django-cms into feature/migrations_history_rewrite
8a5b4a8
Something went wrong with that request. Please try again.