Migrations rewritten #1434

Merged
merged 5 commits into from Oct 12, 2012

Conversation

Projects
None yet
5 participants
@yakky
Contributor

yakky commented Sep 19, 2012

All migrations have been created from scratch using South==0.7.5 and saved as 0001_initial; others are empty just to keep migration history consistent. Thanks @Bouke for suggesting this approach.
This is just a first tentative.

Needs docs (pre 2.3.2 installation needs first to install and upgrade to 2.3.2 and then upgrade to this versione) and tests (automated syncdb / migrate on at least sqlite/pgsql/mysql as suggested by @digi604).

Tested on a sample project both with and without CMS_MODERATOR on

Fixes #1427, but many other opened issues are related to migrations/south: maybe they should be referenced here to address those cases in this PR.

Migration related issues:

Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
@ojii

This comment has been minimized.

Show comment
Hide comment
@ojii

ojii Sep 20, 2012

Collaborator

I think we should ask @andrewgodwin what he thinks about this approach. (Please apologize my rude pinging Andrew)

Collaborator

ojii commented Sep 20, 2012

I think we should ask @andrewgodwin what he thinks about this approach. (Please apologize my rude pinging Andrew)

@andrewgodwin

This comment has been minimized.

Show comment
Hide comment
@andrewgodwin

andrewgodwin Sep 20, 2012

Looks alright to me - provided you make sure everyone has migrated to the most recent migrations in all apps before they pull these changes.

Looks alright to me - provided you make sure everyone has migrated to the most recent migrations in all apps before they pull these changes.

@digi604

This comment has been minimized.

Show comment
Hide comment
@digi604

digi604 Oct 4, 2012

Contributor

Still missing:

Contributor

digi604 commented Oct 4, 2012

Still missing:

@yakky

This comment has been minimized.

Show comment
Hide comment
@yakky

yakky Oct 4, 2012

Contributor

Yes sorry, currently quite busy.
I can work on it next week

Contributor

yakky commented Oct 4, 2012

Yes sorry, currently quite busy.
I can work on it next week

@digi604

This comment has been minimized.

Show comment
Hide comment
@digi604

digi604 Oct 4, 2012

Contributor

Referencing some tickets: #1032

Contributor

digi604 commented Oct 4, 2012

Referencing some tickets: #1032

@digi604

This comment has been minimized.

Show comment
Hide comment
@digi604

digi604 Oct 11, 2012

Contributor

any updates here?

Contributor

digi604 commented Oct 11, 2012

any updates here?

beniwohli and others added some commits Oct 11, 2012

Migrations rewritten: all migrations has been created from scratch us…
…ing using South==0.7.5 and saved as 0001_initial; all others are empty just to keep migration history consistent
@yakky

This comment has been minimized.

Show comment
Hide comment
@yakky

yakky Oct 12, 2012

Contributor

I'm having some issues with multi-db tests.
There are many failing tests on postgres and mysql, some fails as they assume sqlite (e.g. query-counting test); fails differ from postgres to mysql.
Tests fail porting multi-db tests on current develop or using SOUTH_TESTS_MIGRATE = False , so it's not migrations related.
I'd skip multi-db in this PR, and create a new one to work on it separately

Contributor

yakky commented Oct 12, 2012

I'm having some issues with multi-db tests.
There are many failing tests on postgres and mysql, some fails as they assume sqlite (e.g. query-counting test); fails differ from postgres to mysql.
Tests fail porting multi-db tests on current develop or using SOUTH_TESTS_MIGRATE = False , so it's not migrations related.
I'd skip multi-db in this PR, and create a new one to work on it separately

@digi604

This comment has been minimized.

Show comment
Hide comment
@digi604

digi604 Oct 12, 2012

Contributor

ok

Contributor

digi604 commented Oct 12, 2012

ok

Merge branch 'feature/migrations_history_rewrite' of github.com:yakky…
…/django-cms into feature/migrations_history_rewrite
@yakky

This comment has been minimized.

Show comment
Hide comment
@yakky

yakky Oct 12, 2012

Contributor

Pushed documentation changes,
Upmf, don't know why github took piquadrat commit too

Contributor

yakky commented Oct 12, 2012

Pushed documentation changes,
Upmf, don't know why github took piquadrat commit too

digi604 added a commit that referenced this pull request Oct 12, 2012

@digi604 digi604 merged commit 2b95e08 into divio:develop Oct 12, 2012

1 check passed

default The Travis build passed
Details
@yakky

This comment has been minimized.

Show comment
Hide comment
@yakky

yakky Oct 12, 2012

Contributor

Created new PR for multi-db testing.

Contributor

yakky commented Oct 12, 2012

Created new PR for multi-db testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment