Plugin cancel button doesn't work when using a PlaceholderField with a custom model - Issue 1452 #1461

Merged
merged 5 commits into from Oct 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

kux commented Oct 3, 2012

The issue is fixed in placeholderadmin, but the 'cancel' button logic is duplicated with the one in pageadmin. However, the 'edit_plugin' (and other plugin handling methods) already has most of it's logic duplicated in the two modules. I could refactor the code and remove all duplication, but the changeset would be quite massive and would probably require some design decisions.

Besides the issue, also improved test coverage and fixed a couple of miss behaving tests.

kux added some commits Oct 1, 2012

* fixed 'cancel' button on edit plugin form (when used in as PluginFi…
…eld in a custom model)

* mind that the fix duplicates code from pluginadmin.py; however, this seems to be the common pattern (most of the edit_plugin method is already duplicated)
Contributor

digi604 commented Oct 3, 2012

travis fails

digi604 added a commit that referenced this pull request Oct 4, 2012

Merge pull request #1461 from kux/issue_1452
Plugin cancel button doesn't work when using a PlaceholderField with a custom model - Issue 1452

@digi604 digi604 merged commit f23a2e6 into divio:develop Oct 4, 2012

1 check passed

default The Travis build passed
Details
Contributor

kux commented Oct 7, 2012

This doesn't fix issue #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment