Fix for #1484 #1485

merged 2 commits into from Oct 19, 2012


None yet
2 participants

yakky commented Oct 18, 2012

Added checks for 'slug' key in cleaned_data to avoid errors during page validation
Reworked error messages to be raised against slug field instead of published.

Fixes #1484


yakky commented Oct 18, 2012

Ops, sorry: I haven't seen @neoascetic already pushed a fix for that in develop.
This fixes some other cosmetic inconsistency, though.
If a 2.3.x release is considered, I think a fix for #1484 (this or @neoascetic's ) should be included as it's a regression introduced in 2.3.2 (porting is trivial, I can open a PR against master if needed)

@digi604 digi604 added a commit that referenced this pull request Oct 19, 2012

@digi604 digi604 Merge pull request #1485 from yakky/feature/slug_check
Fix for #1484

@digi604 digi604 merged commit af529e6 into divio:develop Oct 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment