Fix two links to images in CSS files. #1508

Merged
merged 1 commit into from Nov 12, 2012

Conversation

Projects
None yet
3 participants
@aaugustin
Contributor

aaugustin commented Nov 12, 2012

When the CachedStaticFilesStorage backend is used, ./manage.py collectstatic chokes on broken links in CSS. For more background on
this issue see https://code.djangoproject.com/ticket/18958.

@ojii

This comment has been minimized.

Show comment Hide comment
@ojii

ojii Nov 12, 2012

Collaborator

@aaugustin just promised me to add tests to this later tonight, so let's wait for that with merging

Collaborator

ojii commented Nov 12, 2012

@aaugustin just promised me to add tests to this later tonight, so let's wait for that with merging

@aaugustin

This comment has been minimized.

Show comment Hide comment
@aaugustin

aaugustin Nov 12, 2012

Contributor

The test will run collectstatic with the CachedStaticFilesStorage backend to prevent further regressions in this area.

Contributor

aaugustin commented Nov 12, 2012

The test will run collectstatic with the CachedStaticFilesStorage backend to prevent further regressions in this area.

Fix two links to images in CSS files.
When the `CachedStaticFilesStorage` backend is used, `./manage.py
collectstatic` chokes on broken links in CSS. For more background on
this issue see https://code.djangoproject.com/ticket/18958.
@aaugustin

This comment has been minimized.

Show comment Hide comment
@aaugustin

aaugustin Nov 12, 2012

Contributor

I checked that the test is skipped under Django 1.3 (with Python 2.5) and passes under Django 1.4 (with Python 2.7).

@ojii I'll let your industrial-grade setup test the other combinations if necessary :)

Contributor

aaugustin commented Nov 12, 2012

I checked that the test is skipped under Django 1.3 (with Python 2.5) and passes under Django 1.4 (with Python 2.7).

@ojii I'll let your industrial-grade setup test the other combinations if necessary :)

@ojii

This comment has been minimized.

Show comment Hide comment
@ojii

ojii Nov 12, 2012

Collaborator

tests pass on py 2.5-2.7 on 1.3 and 1.4. fail against django trunk, but they do on develop anyway.

Collaborator

ojii commented Nov 12, 2012

tests pass on py 2.5-2.7 on 1.3 and 1.4. fail against django trunk, but they do on develop anyway.

@ojii ojii merged commit f9715cd into divio:develop Nov 12, 2012

1 check passed

default The Travis build passed
Details
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jan 27, 2014

Coverage Status

Changes Unknown when pulling f9715cd on aaugustin:develop into * on divio:develop*.

Coverage Status

Changes Unknown when pulling f9715cd on aaugustin:develop into * on divio:develop*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment