Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Picture plugin: Add support for width and height #1520

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Collaborator

mkoistinen commented Nov 17, 2012

Model updated with supporting fields to hold width/height, template now uses same.

Member

digi604 commented Nov 27, 2012

migrations are missing.

Member

digi604 commented Nov 27, 2012

and maybe add the widht and hight in a default hidden advanced tab in the form.

Contributor

beniwohli commented Nov 27, 2012

Are we sure we need these fields? Natural width and height are available on the ImageField instance, and if the image needs to be scaled, it's probably a better idea to use something like easy_thumbnails and the width value provided from the placeholder.

Member

digi604 commented Mar 28, 2013

I close this pull request as i think @piquadrat is right on this one.

@digi604 digi604 closed this Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment