PlaceholderAdmin degradated to a mixin class #2728

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jrief commented Feb 25, 2014

not ready for merging.
Unit testing throws error in
ERROR: test_copy_to_from_clipboard (cms.tests.frontend.PlaceholderBasicTests)

Coverage Status

Coverage remained the same when pulling 33090e1 on jrief:issue-2709 into 41dea10 on divio:develop.

Member

digi604 commented Feb 26, 2014

Ok this is a drastic backwards incompatible change. Like yakky suggested i would create a PlaceholderAdminMixin class and make PlaceholderAdmin usable as before:

PlaceholderAdmin(PlaceholderAdminMixin, admin.ModelAdmin):
    def __init__(self, *args, **kwargs):
          warnings.warn('Deprecation warning: PlaceholderAdmin is deprecated.... bla bla')
          super(PlaceholderAdmin, self).__init__(*args, **kwargs)

jrief referenced this pull request Feb 27, 2014

Merged

Fix issue 2709 #2740

Member

digi604 commented Feb 27, 2014

closing

digi604 closed this Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment