Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.picture image should accept rel attribute info #276

Closed
italomaia opened this issue Dec 1, 2009 · 10 comments
Closed

plugins.picture image should accept rel attribute info #276

italomaia opened this issue Dec 1, 2009 · 10 comments

Comments

@italomaia
Copy link

Doing this, slimbox will became easier to use. rel="lightbox" makes slimbox capture the image.

@digi604
Copy link
Contributor

digi604 commented Dec 1, 2009

do you mean in the admin?
Why you don't just overwrite the template for certain placeholders?

@italomaia
Copy link
Author

Yeap, in the admin. Well, it seemed a common use, as the link field gives you a hyperlink to the image to have a way to edit it's rel. Just the first line of the default template woulf have to change. Something like this works:

{% if link %}{% endif %}

In the model, the change is very slim too.

@dstufft
Copy link
Contributor

dstufft commented Dec 3, 2009

I support this as well, all the link / picture items should have all the attributes available (but optional) like rel, class, etc.

@digi604
Copy link
Contributor

digi604 commented Dec 3, 2009

I would support this if this fields are hidden in an advanced tab

@italomaia
Copy link
Author

Seems like a good deal to me ^^

@digi604
Copy link
Contributor

digi604 commented Dec 4, 2009

just before someone goes ahead and implements it....
why don't you solve it over the template?

@dstufft
Copy link
Contributor

dstufft commented Dec 4, 2009

what do you mean? why don't we override the template for pictures? If so mostly because i don't want the rel="shadowbox" attribute on all of my pictures which is where i would use this at.

@digi604
Copy link
Contributor

digi604 commented Dec 4, 2009

do you don't want it on pictures that are in the same or in different placeholders?

@dstufft
Copy link
Contributor

dstufft commented Dec 4, 2009

Depends on the image, often times i will have images in the same placeholder that i want some of them to have a rel attribute and other ones not too. I don't really see a reason not to allow this so i think i'll try to get this done over this weekend. It's really the only local patch i have left that i have to apply to a checkout.

@ojii
Copy link
Contributor

ojii commented Sep 17, 2010

use a custom plugin if you need extra functionality

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants