Skip to content

Conversation

@yakky
Copy link
Member

@yakky yakky commented Jan 15, 2015

This templatetag is a version of render_placeholder which does not use cache, in a similar way to show_placeholder, show_uncached_placeholder

@yakky yakky added this to the 3.1 milestone Jan 15, 2015
@yakky
Copy link
Member Author

yakky commented Jan 15, 2015

#3702 rebased on develop

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 74e4c4e on yakky:feature/render_placeholder_uncached into 2ef8998 on divio:develop.

@yakky
Copy link
Member Author

yakky commented Jan 16, 2015

Ping @ojii @mkoistinen @digi604 this fill in a gap in the api

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cached or taken from the cache

@mkoistinen
Copy link
Contributor

@yakky, it is unclear to me what should happen if someone adds a plugin with cache=True to a placeholder that is rendered with either show_uncached_placeholder or render_uncached_placeholder. What is the correct behaviour? Also, once we decide this, can we add some tests to protect the decided upon behaviour? I can see this getting flip-flopped a lot over time.

Otherwise LGTM

@yakky
Copy link
Member Author

yakky commented Feb 21, 2015

Caching is only at placeholder level, and cache = True only means: "Ok placeholder, I can be cached if you're up to".
So using show_uncached_placeholder / render_uncached_placeholder effectively disables any caching (both read and write), ignoring plugins attribute.
The current test coverage should already address this

@yakky yakky force-pushed the feature/render_placeholder_uncached branch from 001a77a to 2eaf0bd Compare February 21, 2015 07:44
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 90.96% when pulling 2eaf0bd on yakky:feature/render_placeholder_uncached into 4560601 on divio:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 90.96% when pulling 2eaf0bd on yakky:feature/render_placeholder_uncached into 4560601 on divio:develop.

@coveralls
Copy link

coveralls commented Feb 21, 2015

Coverage Status

Coverage decreased (-0.09%) to 90.431% when pulling 74e4c4e on yakky:feature/render_placeholder_uncached into 2ef8998 on divio:develop.

@yakky
Copy link
Member Author

yakky commented Feb 21, 2015

@mkoistinen task completed

@mkoistinen
Copy link
Contributor

lgtm

yakky added a commit that referenced this pull request Feb 21, 2015
Add render_uncached_placeholder templatetag
@yakky yakky merged commit 0b0b4bb into django-cms:develop Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants