Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename draft publish buttons #6052

Merged

Conversation

stefanfoulis
Copy link
Contributor

Summary

Removes "page" text from the draft/publish buttons

The buttons at the top right in the Toolbar used to be called
"Edit page" and "View published page". Since there is an increasing
number of non Page content using those buttons, I removed the reference
to page to make it more universal and shorter.

This has changed a translation string, so the translations need to be updated too.

@stefanfoulis stefanfoulis self-assigned this Aug 21, 2017
@stefanfoulis stefanfoulis changed the base branch from release/3.4.x to develop August 21, 2017 08:36
@stefanfoulis stefanfoulis reopened this Aug 21, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5bf81bf on stefanfoulis:feature/rename-draft-publish-buttons into ** on divio:develop**.

@stefanfoulis stefanfoulis force-pushed the feature/rename-draft-publish-buttons branch from 5bf81bf to e7d6ee9 Compare August 21, 2017 09:32
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.634% when pulling e7d6ee9 on stefanfoulis:feature/rename-draft-publish-buttons into dc97d74 on divio:develop.

@stefanfoulis stefanfoulis force-pushed the feature/rename-draft-publish-buttons branch from e7d6ee9 to 184f7aa Compare August 21, 2017 11:24
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.634% when pulling 184f7aa on stefanfoulis:feature/rename-draft-publish-buttons into dc97d74 on divio:develop.

The buttons at the top right in the Toolbar used to be called
"Edit page" and "View published page". Since there is an increasing
number of non Page content using those buttons, I removed the reference
to page to make it more universal and shorter.

Renames the source msgid from "View published page" to "View published".
Translations left untouched. A string for "Edit" already exists.
@stefanfoulis stefanfoulis force-pushed the feature/rename-draft-publish-buttons branch from 184f7aa to 53a3bc9 Compare August 21, 2017 13:40
@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage remained the same at 79.634% when pulling 53a3bc9 on stefanfoulis:feature/rename-draft-publish-buttons into dc97d74 on divio:develop.

@czpython czpython merged commit 9b6264b into django-cms:develop Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants