Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase #6667

Merged
merged 4 commits into from Aug 8, 2019

Conversation

@jeroenpeters1986
Copy link
Contributor

commented Apr 8, 2019

Added prepopulated_fields to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)

Summary

Fixes #

Links to related discussion

Proposed changes in this pull request

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • I have updated the release notes document if appropriate, with:
    • general notes
    • bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

jeroenpeters1986 added some commits Apr 8, 2019

Add 'prepopulated_fields' to ignore list
Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)
@jeroenpeters1986

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

I looked this up more than once to see if it would work, I thought it might save other some time to also add prepopulate_fields to the ignore list.

@coveralls

This comment has been minimized.

Copy link

commented Apr 8, 2019

Coverage Status

Coverage remained the same at 78.215% when pulling 33d1ee4 on jeroenpeters1986:patch-1 into 4c754d0 on divio:develop.

@FinalAngel

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Thank you very much @jeroenpeters1986 for the contribution :)

@FinalAngel FinalAngel added this to the 3.7.x milestone Aug 7, 2019

@FinalAngel FinalAngel merged commit 31d1295 into divio:develop Aug 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

FinalAngel added a commit to FinalAngel/django-cms that referenced this pull request Aug 8, 2019

Documenation: Add 'prepopulated_fields' to ignored options list on CM…
…SPluginBase (divio#6667)

* Add 'prepopulated_fields' to ignore list

Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)

* Update AUTHORS

FinalAngel added a commit to FinalAngel/django-cms that referenced this pull request Aug 8, 2019

Documenation: Add 'prepopulated_fields' to ignored options list on CM…
…SPluginBase (divio#6667)

* Add 'prepopulated_fields' to ignore list

Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)

* Update AUTHORS

FinalAngel added a commit that referenced this pull request Aug 8, 2019

Documenation: Add 'prepopulated_fields' to ignored options list on CM…
…SPluginBase (#6667) (#6713)

* Add 'prepopulated_fields' to ignore list

Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)

* Update AUTHORS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.