Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation and files for 3.7 LTS #6761

Merged
merged 3 commits into from Nov 12, 2019
Merged

Conversation

@FinalAngel
Copy link
Member

FinalAngel commented Nov 11, 2019

Summary

This PR improves on GitHub issue creation and Contribution guidelines.

General checklist

  • I have updated the CHANGELOG.txt
FinalAngel added 2 commits Nov 11, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 11, 2019

Coverage Status

Coverage remained the same at 78.215% when pulling 961e17f on FinalAngel:develop into 9cb5ab6 on divio:develop.

@FinalAngel FinalAngel requested a review from evildmp Nov 11, 2019
Copy link
Contributor

evildmp left a comment

Two small changes suggested

@FinalAngel

This comment has been minimized.

Copy link
Member Author

FinalAngel commented Nov 12, 2019

@evildmp thanks and adapted :)

@FinalAngel FinalAngel merged commit 857174d into divio:develop Nov 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
FinalAngel added a commit to FinalAngel/django-cms that referenced this pull request Nov 12, 2019
* general updates

* updates from comments

* update form comments
FinalAngel added a commit that referenced this pull request Nov 12, 2019
* Improved and simplified permissions documentation (#6224)

[ci-skip]

* Updated branch policy (#6320)

* Updated branch policy

[ci only docs]

* Removed feature branch notes from policy

* Improve apphooks documentation (#6743)

Remove a reference to `urls` attribute on AppHook class in the documentation.

* Fix documentation bug regarding CMSPluginBase (#6744)

The documentation advertises that you can set the module attribute of
custom plugins to None.  If the user attempts this django they won't be able
to start up when django.contrib.admin.site.urls is included in urls.py
(tested with django 1.11.25 and django-cms 3.7.0).

* Added example of `get_plugin_instance` to the docs on nested plugins. (#6609)

* Amend Changelog and fixes from merged PRs (#6755)

* add missing changelog entries

* update docs

* updated changelog

* updates from comments

* Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (#6679)

* Pass site object instead of pk when rendering menu

Add original fix by @saqlainsyed007

* Moved test to it's own class

* Update changelog

* Do not let non-staff users to log in via CMS Toolbar (#6705)

* Merged stale PR's (#6759)

* add missing changelog entries

* update docs

* updated changelog

* updates from comments

* merge #6347

* merged #6530

* merge #6538

* merge #6549

* merge #6704

* changelog for #6705

* Update issue templates

* Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738)

* Refs #6737 -- Add test for apphooks urls config check

* Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls

When rewriting the apphooks urls in appresolver.recurse_patterns,
the original RegexPattern.is_endpoint flag is lost, so urls with a callback
view throws an "include with a route ending with a '$'" warning ('urls.W001').

    @apphook_pool.register
    class MyApp(CMSApp):
        name = "MyApp"

        def get_urls(self, page=None, language=None, **kwargs):
            return [
                re_path(r"^$", views.MyAppView.as_view(), name="my-app-index")
                # or this
                # path(r"", views.MyAppView.as_view(), name="my-app-index")
            ]

    $ ./manage.py check
    System check identified some issues:

    WARNINGS:
    ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index']
    uses include with a route ending with a '$'. Remove the dollar from the
    route to avoid problems including URLs.

This fix set the RegexPattern flag is_endpoint to True for callback views
in appresolver.recurse_patterns as in
https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70

* Updated documentation and files for 3.7 LTS (#6761)

* general updates

* updates from comments

* update form comments
FinalAngel added a commit that referenced this pull request Nov 26, 2019
* Add missing parenthesis in code (#6677) (#6690)

* Adding support for Django 2.2 LTS (#6655) (#6691)

* New changes for cms 3.7

* Fix typo

* Fixed issue with force_color

* Removed unused import

* Added docs to index.rst

* Fixed travis jobs

* Fixed force_color command

* Changes after review

* Fixed django version in setup

* Update django-2.2.txt

* Fixes test suite (#6688) (#6692)

* add information for testing

* fix tests

* updated CHANGELOG

* update

* 1.8.5

* fix tests locally

* update text

* Release 3.7.0a1 (internal) (#6693)

* bumped version to 3.7.0a1

* updated staticfiles

* updated translations

* Adapt test suite for recent Travis changes (#6709) (#6710)

* test something

* further updates and add 3.7 to test

* updates

* simplify for tests

* add 3.7 support

* Fix content mode related to #6694 (#6696) (#6711)

* Adapt test suite for recent Travis changes (#6709)

* test something

* further updates and add 3.7 to test

* updates

* simplify for tests

* add 3.7 support

* Fix content mode related to #6694 (#6696)

* Fix content mode related to #6694

* Add Dmytro Litvinov to AUTHORS according to PR template

* Self install doc tweaks (#6673) (#6712)

* Adapt test suite for recent Travis changes (#6709)

* test something

* further updates and add 3.7 to test

* updates

* simplify for tests

* add 3.7 support

* Fix content mode related to #6694 (#6696)

* Fix content mode related to #6694

* Add Dmytro Litvinov to AUTHORS according to PR template

* Self install doc tweaks (#6673)

* Add missing template context processor to self install docs

Fixes #5828

* Reword self install docs for clarity

* Add to AUTHORS file

* Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (#6667) (#6713)

* Add 'prepopulated_fields' to ignore list

Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin)

* Update AUTHORS

* Release 3.7.0rc1 (#6715)

* update django version in sphinx

* bumped version

* updated existing translations

* update static files

* update docs

* update authors file

*  Override urlconf_module so that Django system checks don't crash. (#6719) (#6723)

* Add a test case for #6717.

* Override urlconf_module so that Django system checks don't crash.

Without this fix, Django system checks in Django 2.2 will try to resolve the
"app_resolver" module, which does not exist. Overriding ``urlconf_module``
prevents the issue.

Fixes #6717

* Release 3.7.0rc2 (#6724)

* regenerated translation files

* bumped version

* update existing translation

* compile static files

* updated release notes

* Updated compatibility table (#6727)

* Release 3.7.0 (#6735)

* Bumped version to 3.7.0

* updated translation files

* added static files

* Backport to prepare for 3.7.1 (#6762)

* Improved and simplified permissions documentation (#6224)

[ci-skip]

* Updated branch policy (#6320)

* Updated branch policy

[ci only docs]

* Removed feature branch notes from policy

* Improve apphooks documentation (#6743)

Remove a reference to `urls` attribute on AppHook class in the documentation.

* Fix documentation bug regarding CMSPluginBase (#6744)

The documentation advertises that you can set the module attribute of
custom plugins to None.  If the user attempts this django they won't be able
to start up when django.contrib.admin.site.urls is included in urls.py
(tested with django 1.11.25 and django-cms 3.7.0).

* Added example of `get_plugin_instance` to the docs on nested plugins. (#6609)

* Amend Changelog and fixes from merged PRs (#6755)

* add missing changelog entries

* update docs

* updated changelog

* updates from comments

* Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (#6679)

* Pass site object instead of pk when rendering menu

Add original fix by @saqlainsyed007

* Moved test to it's own class

* Update changelog

* Do not let non-staff users to log in via CMS Toolbar (#6705)

* Merged stale PR's (#6759)

* add missing changelog entries

* update docs

* updated changelog

* updates from comments

* merge #6347

* merged #6530

* merge #6538

* merge #6549

* merge #6704

* changelog for #6705

* Update issue templates

* Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738)

* Refs #6737 -- Add test for apphooks urls config check

* Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls

When rewriting the apphooks urls in appresolver.recurse_patterns,
the original RegexPattern.is_endpoint flag is lost, so urls with a callback
view throws an "include with a route ending with a '$'" warning ('urls.W001').

    @apphook_pool.register
    class MyApp(CMSApp):
        name = "MyApp"

        def get_urls(self, page=None, language=None, **kwargs):
            return [
                re_path(r"^$", views.MyAppView.as_view(), name="my-app-index")
                # or this
                # path(r"", views.MyAppView.as_view(), name="my-app-index")
            ]

    $ ./manage.py check
    System check identified some issues:

    WARNINGS:
    ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index']
    uses include with a route ending with a '$'. Remove the dollar from the
    route to avoid problems including URLs.

This fix set the RegexPattern flag is_endpoint to True for callback views
in appresolver.recurse_patterns as in
https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70

* Updated documentation and files for 3.7 LTS (#6761)

* general updates

* updates from comments

* update form comments

* Further backports for 3.7.1 (#6768)

* add newly generated strings

* Fix simple typo: seperated -> separated (#6767)

* Fix simple typo: seperated -> separated

* Update CHANGELOG.rst

* Update djangocms installer docs (#6764)

* Release django CMS 3.7.1 (#6769)

* update documentation

* Bumped version to 3.7.1

* compiled available languages

* update static files

* fix build

* bump date

* rebundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.