updated jQuery UI to 1.8.15 #943

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants

kayluhb commented Aug 13, 2011

Update jQuery UI to the most recent version.

Collaborator

ojii commented Aug 14, 2011

This is just too big a change (and not necessary?) for 2.2, will bump to 2.3

kayluhb commented Aug 14, 2011

Thanks for the response.

It's actually not as big of a change as it would seem and I definitely need it on my current project and future projects. I'll keep working with my fork and let you know if I encounter any problems. Consider it testing for 2.3?

Thanks again.

Collaborator

ojii commented Aug 14, 2011

Well the 'big change' is it updates a dependency we have 0 test coverage on... and since I want to get 2.2 out ASAP, this is just too big a risk

kayluhb commented Aug 14, 2011

Oh, yea. I definitely agree. I wasn't trying to get it into 2.2, just trying to make it easier for when it can be rolled in.

Collaborator

ojii commented Aug 14, 2011

appreciate it

Contributor

digi604 commented Aug 10, 2012

Could this be updated and testet with 1.8.22?

After that we should be able to merge with all the other JS changes.

darklow commented Mar 25, 2013

Is there any particular/specific reason why django-cms uses so old jquery and jquery-ui versions?
Will the valid pull request on update to latest jquery and jquery-ui versions will be appreciated?

Collaborator

ojii commented Mar 26, 2013

The reason is the horrible backwards compatibility of jQuery. Also, the CMS jQuery should not leak to the webpage and therefore should not interfere with user JavaScript. I no reason to upgrade our jQuery

darklow commented Mar 26, 2013

@ojii What if i could help resolve all the issues, then would update to newest jquery version will be accepted?
The problem is django-cms ir not the only app in Django admin, we have plenty more apps and modules, like select2, django-suit and as soon as you add django-cms there are tons of scripts that interfere, and have problems because of old jquery, which have lack of bind, on and lot of other features.

You can't live forever on that old jquery, or otherwise it should be wrapped in some djangocms namespace, like django admin did.

Collaborator

ojii commented Mar 26, 2013

The thing that needs to be fixed is our namespacing/isolation. I just don't trust upgrading jQuery. As stated above, as long as we have 0% JS test coverage, I don't feel comfortable about upgrading it unless we 100% need it.

Contributor

evildmp commented Mar 26, 2013

On Mon, Mar 25, 2013, Jonas Obrist notifications@github.com wrote:

The reason is the horrible backwards compatibility of jQuery. Also, the
CMS jQuery should not leak to the webpage and therefore should not
interfere with user JavaScript. I no reason to upgrade our jQuery

It's true that jQuery should not leak to the webpage, but there are also cases where it interferes with other applications' jQuery needs, particularly when they are using django CMS features such as placeholders.

Daniele

Collaborator

ojii commented Mar 26, 2013

I'll just keep repeating myself. All our JS should be isolated on the CMS namespace, everything else is a bug.

So I'll close this issue, I'm really not interested in upgrading it unless we need it for something internal.

@ojii ojii closed this Mar 26, 2013

darklow commented Mar 26, 2013

All our JS should be isolated on the CMS namespace, everything else is a bug.

You keap repeating, but don't give us any hints on what to do.
Magic words: should be - so is it a bug awaiting for somebody's pull request?
So to finalize: is it worth spending time wrapping django-cms in CMS namespace and PR will be accepted or is it in plans doing by django-cms staff?

Collaborator

ojii commented Mar 26, 2013

open a new bug telling us where this fails. then we'll look into fixing this.

If you can write a patch that will fix those isolation issues, even better! (beer on me!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment