Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Placeholder scanning is broken with cached template loader. #960

Merged
merged 1 commit into from Aug 25, 2011

Conversation

Projects
None yet
2 participants
Contributor

stephrdev commented Aug 19, 2011

This fixes the placeholder scanning/template parsing when using the cached template loader.

Without this fix the test suite will freeze/infinite loop while parsing the templates.

To test this, we need to run the test suite two times, 1) without cached template loader 2) with cached template loader. I don't know if a testcase with settings override will work.

@stephrdev stephrdev This fixes the placeholder scanning/template parsing when using the c…
…ached template loader.

Without this fix the test suite will freeze/infinite loop while parsing the templates.
88f5784
Contributor

stephrdev commented Aug 19, 2011

The problem first occured with this change: 62e419e

Collaborator

ojii commented Aug 25, 2011

looks sane, thanks

@ojii ojii added a commit that referenced this pull request Aug 25, 2011

@ojii ojii Merge pull request #960 from stephrdev/feature/fix_cached_loader
Placeholder scanning is broken with cached template loader.
a129321

@ojii ojii merged commit a129321 into divio:develop Aug 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment