a fix for 977, couldn't reproduce the bug using unittests (but using the #982

Merged
merged 1 commit into from Sep 2, 2011

Conversation

Projects
None yet
2 participants
Collaborator

ojii commented Sep 1, 2011

This fixes #977

No clue what those lines were supposed to do in the first place, but since I was unable to reproduce the issue using a unittest (but using the browser it was fairly trivial), this pull request should be thought through before merging.

The tests still pass, but we all know how good our permmod coverage is...

Jonas Obrist a fix for 977, couldn't reproduce the bug using unittests (but using …
…the browser). So really NOT sure if this is a valid fix!
bdceb4e
Collaborator

chrisglass commented Sep 2, 2011

Well, this tells to comment our code better... there has to be a reason why this was put there in the first place :)

I will become a douchebag now and systematically oppose under commented pull requests :)

Collaborator

ojii commented Sep 2, 2011

Found the commit introducing those lines 36b55b5

Yes it was me and I apologize for not commenting what the hell I was thinking I was doing there. Also I have no clue what the idea was back then...

/me hides in shame...

Collaborator

chrisglass commented Sep 2, 2011

Ah well, as discussed, let's merge this, we'll see if something comes up in rc-3 :)

chrisglass merged commit 5f3c331 into divio:develop Sep 2, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment