fixing js issue: placeholder id on plugin-list-holder was not set. #999

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

benzkji commented Sep 9, 2011

$(this).parent().parent().data('id');

is used for adding, copying and sorting plugins, but the property is not set?
so I added it for all div.plugin-list-holder elements...maybe this should work differently? but I don't see how at the moment.

regards
ben

Contributor

benzkji commented Sep 9, 2011

sorry, some info missing (taken from #998, as I'm not yet fully github certified...):

using the 2.2rc3, I am no more able to add plugins in the backend.
the ajax post request sends placeholder_id='null'

I made a small correction in cms/static/cms/js/plugin_editor.js that solves the problem for me (see me pull request). this might not be the best possible solution, but for me it works now.

Collaborator

ojii commented Sep 9, 2011

The ID is set in https://github.com/divio/django-cms/blob/develop/cms/templates/admin/cms/page/widgets/plugin_editor.html#L24

This issue is likely due to outdated templates and/or static files

ojii closed this Sep 9, 2011

Contributor

benzkji commented Sep 12, 2011

completely right. sorry for toying around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment