New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring GitSavvy settings and project-wise settings #908

Merged
merged 4 commits into from Apr 7, 2018

Conversation

Projects
None yet
2 participants
@randy3k
Collaborator

randy3k commented Mar 30, 2018

this adds support of project-wise settings by refactoring settings related code.

A new command Preference: GitSavvy Project Settings is also added to allow easier editing.

@randy3k randy3k changed the title from refactoring GitSavvy settings to refactoring GitSavvy settings and project-wise settings Mar 31, 2018

randy3k added some commits Mar 30, 2018

Internal: use SettingsMixin
it is the first step towards project-wise settings
@@ -61,3 +61,28 @@ class GsEditSettingsCommand(WindowCommand):
"""
def run(self, **kwargs):
self.window.run_command("edit_settings", kwargs)

This comment has been minimized.

@stoivo

stoivo Apr 7, 2018

Collaborator

This should have been in the later commit but ¯_(ツ)_/¯

@stoivo

stoivo Apr 7, 2018

Collaborator

This should have been in the later commit but ¯_(ツ)_/¯

This comment has been minimized.

@randy3k

randy3k Apr 7, 2018

Collaborator

Ya, maybe.

@randy3k

randy3k Apr 7, 2018

Collaborator

Ya, maybe.

@stoivo

This comment has been minimized.

Show comment
Hide comment
@stoivo

stoivo Apr 7, 2018

Collaborator

Looking good

Collaborator

stoivo commented Apr 7, 2018

Looking good

@randy3k

This comment has been minimized.

Show comment
Hide comment
@randy3k

randy3k Apr 7, 2018

Collaborator

Though I have been using this branch for a while, I am still not 100% nothing breaks. However, let's merge it and test.

Collaborator

randy3k commented Apr 7, 2018

Though I have been using this branch for a while, I am still not 100% nothing breaks. However, let's merge it and test.

@randy3k randy3k merged commit e2341ba into dev Apr 7, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 31.586%
Details

@randy3k randy3k deleted the settings branch Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment