Remove inspect method for Python 3.11 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had to disable the integration CI checks due to problems in the Windows image. Seems like WinRM is just timing out when attempting to connect to itself in the latest images. I've manually tested out the changes here against a proper Windows host and things are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect.getargspecwas deprecated and is now removed in python 3.11. This removes the usage of this function and bumps the minimum version forrequests-ntlmto ensure the arguments specified are valid. The version ofrequests-ntlmhas been out for 5 years so so it should be safe to set as a minimum.