dj2
Follow
dj2
Follow
Popular repositories
-
-
async-rack Public
Forked from rkh/async-rack
Makes middleware that ships with Rack bullet-proof for async responses.
-
-
ObjectiveC-UnitTest-Example Public
A repo with an Objective-C project setup with OCUnit and OCMock
1,002 contributions in the last year
Contribution activity
May 2022
Created 116 commits in 3 repositories
Created a pull request in gpuweb/gpuweb that received 6 comments
Use table formatting for texture builtins.
This PR changes the texture builtins to use tables similar to the other builtins. For the signatures are collapsed where possible and the precondit…
+885
−221
•
6
comments
Opened 54 other pull requests in 2 repositories
gpuweb/cts
49
merged
- wgsl: Stub synchronization builtin functions.
- wgsl: Add stubs for the pack and unpack methods.
- wgsl: Stub tests for the textureStore builtin.
- wgsl: Add stub tests for textureSampleLevel.
- wgsl: Add stub tests for textureSampleGrad.
- wgsl: Add stub tests for textureSampleCompareLevel.
- wgsl: Stub tests for textureSampleCompare
- wgsl: Add stubs for the read-write-modify atomic operations.
- wgsl: Add stubs for the atomicStore builtin.
- wgsl: Stub tests for the atomicLoad builtin.
- wgsl: Add stub tests for the textureSample builtin.
- Add skipLibCheck to tsconfig.json
- wgsl: Fixup coord parameters in texture tests.
- wgsl: Add stub tests for textureNumSamples
- wgsl: Stub tests for textureNumLevels builtin.
- wgsl: Stub tests for textureNumLayers builtin
- wgsl: Stub tests for textureLoad builtin.
- wgsl: Cleanup duplicate description text
- wgsl: Stub textureSampleBias tests
- wgsl: update textureGather tests
- [dawn-node]: Move TSC config to file.
- wgsl: Adds stub tests for textureGatherCompare
- wgsl: Stub tests for the textureGather builtin.
- wgsl: Stub tests for textureDimension.
- [wgsl] Add missing @const decorations.
- Some pull requests not shown.
Reviewed 18 pull requests in 3 repositories
gpuweb/gpuweb
9 pull requests
- [wgsl]: Clarify attribute Valid Values.
- Change ref<S,T,A> to ref<AS,T,AM>
- Clarify 'S' in the ref<S,T,A> row of the ConversionRank
- Clarify some error types
- Clarify non-normative wording about i32 inference
- Remove multisampled text from textureNumLayers
- Address out-of-bounds sample index in textureLoad
- wgsl: Make float builtin preconditions similar to integer builtins.
- Fix second form of mix
gpuweb/cts
8 pull requests
- Duplicate params: catch in ParamsBuilder, improve error in loadTreeForQuery
-
wgsl: Use
kValue.... instead of converting bit-fields toScalars -
wgsl: Extend
anyOfto acceptComparators - wgsl: Add support for f64 to Scalar
- wgsl: Stub tests for textureDimension.
- wgsl: Generalize unary and binary f32 arithmetic case generation
-
Handle backends flushing inputs in
atan2tests - Add --colors flag for enabling color output
tabatkins/bikeshed
1 pull request
Created an issue in gpuweb/gpuweb that received 4 comments
Clarify Valid Values language in the attributes table.
Currently the Valid Values column says things like integer literal, yielding a positive i32 which I took to mean it could be 1u as an integer liter…
4
comments
Opened 64 other issues in 2 repositories
gpuweb/cts
37
open
2
closed
- Provide ability to dump WGSL shaders
- wgsl: validate conversion rules
- wgsl: Test small magnitude hex floats.
- wgsl: Test small magnitude floats
- wgsl: execution tests for scoping rules
- wgsl: Validate recursion disallowed
- wgsl: validate scoping rules
-
wgsl: validate
global_directive - wgsl: validate pipeline stage attributes
-
wgsl: execution tests for
@workgroup_size -
wgsl: validate
@workgroup_sizeparsing - wgsl: validate all examples in the spec exist in the CTS
- wgsl: Validate various structs with size/align validate correctly.
-
wgsl: validate
@sizeparsing -
wgsl: execution tests for
@location -
wgsl: validate
@locationparsing -
wgsl: execution test for
@invariant -
wgsl: execution tests for
@interpolate -
wgsl: Validate parsing of the
@interpolatebuiltin -
wgsl: validate
@invariantparsing -
wgsl: validate
@builtinparsing -
wgsl: Execution tests for
@id -
wgsl: Validate
@idparsing -
wgsl: Validate each
@builtinvalue can be used as variable names -
wgsl: Add execution tests for
@bindingand@groupvalues - Some issues not shown.
gpuweb/gpuweb
20
open
5
closed
- Conversion expression preamble claims no conversion or promotion of numerics.
- Conversion expressions for the Abstract types
-
Make return types for
modfandfrexpgeneric -
Specify the meaning of
Sin the ConversionRank table - Update note about when automatic conversions occur.
- Example of unary negation overloads is out of date.
- Update or remove note about function declarations containing other declarations
- Valid and Invalid declarations comment for built-in functions is a bit misleading
-
Add example of shadowing function parameter in
Valid and invalid declarationsexample -
Spec prose seems to allow
staticAssertbeforeglobal_directive -
workgroup_sizevalid values -
@interpolatevalues on reserved word list - Confusing languages in technical overview around conversions.
-
textureDimensionmissingi32overload forlevelparameter -
Clarify the normalized float ranges in the
packmethods -
textureSampleLevel missing
externalin definition oft -
textureSampleCompareliststexture_depth_cube_arraytwice. -
externaltextures andtextureSample -
Add texture types to
tfor textureSampleGrad and textureSampleBias - textureSampleCompareLevel missing params and return documentation.
-
textureNumLayerslistsmultisampledas a possibletvalue - textureLoad does not specify bounds for sample_index
-
textureGatherlimits oncoordsandarray_index -
Clarification around
sampled typein the Texture Builtin section. -
Parameterization missing for
arrayLength