-
Notifications
You must be signed in to change notification settings - Fork 3
fix: try to fix the issue with coverage files not uploading #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated the CI test workflow to produce a coverage.xml report and configure the Codecov action to use that file without failing the build on upload errors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Verify that the generated coverage.xml path (./coverage.xml) actually matches the working directory of the workflow so Codecov can find it.
- Double-check that setting fail_ci_if_error to false aligns with your intentions, since upload failures won’t fail the CI run with that flag.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify that the generated coverage.xml path (./coverage.xml) actually matches the working directory of the workflow so Codecov can find it.
- Double-check that setting fail_ci_if_error to false aligns with your intentions, since upload failures won’t fail the CI run with that flag.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 90.81% 90.83% +0.02%
==========================================
Files 18 18
Lines 849 851 +2
Branches 98 98
==========================================
+ Hits 771 773 +2
Misses 48 48
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Summary by Sourcery
Generate coverage.xml and adjust Codecov upload parameters to ensure coverage reports are correctly uploaded without failing the CI.
CI: