Skip to content

Conversation

@vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Oct 26, 2025

Summary by Sourcery

Generate coverage.xml and adjust Codecov upload parameters to ensure coverage reports are correctly uploaded without failing the CI.

CI:

  • Add a coverage xml generation step in the test workflow
  • Configure Codecov action to upload the generated coverage.xml and disable CI failure on upload errors

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated the CI test workflow to produce a coverage.xml report and configure the Codecov action to use that file without failing the build on upload errors.

File-Level Changes

Change Details Files
Generate and upload coverage XML in CI workflow
  • Insert 'coverage xml' after running pytest under coverage
  • Configure codecov-action to use './coverage.xml' as the upload source
  • Disable CI failure on Codecov upload errors by setting 'fail_ci_if_error' to false
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Verify that the generated coverage.xml path (./coverage.xml) actually matches the working directory of the workflow so Codecov can find it.
  • Double-check that setting fail_ci_if_error to false aligns with your intentions, since upload failures won’t fail the CI run with that flag.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Verify that the generated coverage.xml path (./coverage.xml) actually matches the working directory of the workflow so Codecov can find it.
- Double-check that setting fail_ci_if_error to false aligns with your intentions, since upload failures won’t fail the CI run with that flag.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (6b3b2d6) to head (9eb6ab1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   90.81%   90.83%   +0.02%     
==========================================
  Files          18       18              
  Lines         849      851       +2     
  Branches       98       98              
==========================================
+ Hits          771      773       +2     
  Misses         48       48              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@fsbraun fsbraun merged commit 505f469 into main Oct 26, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants