Skip to content

Conversation

@okotdaniel
Copy link
Member

@okotdaniel okotdaniel commented Oct 9, 2025

Description

This pull request adds a new section to the contributing documentation that explains how to build and preview the project documentation locally using Make and Tox.

Previously, contributors did not have clear instructions on generating the documentation before submitting changes.
This update provides step-by-step guidance for both Linux/macOS and Windows users, ensuring a smoother onboarding experience for new contributors.

Fixes #2215

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @okotdaniel! This is really great. Seeing the documentation so well written is solidifying some of my thoughts. I apologize for not having these entirely thought out when we created the issue.

If you disagree with any of my thoughts, please let me know. And where I ask questions, I would like your feedback. Thank you!

@okotdaniel okotdaniel marked this pull request as draft October 10, 2025 11:02
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There are some minor Sphinx syntax cleanup I will do, but I'll get this squashed and merged in today! Thank you for helping future contributors!

@tim-schilling tim-schilling force-pushed the docs/add-docs-generation-guide branch from 005e633 to 57f9abb Compare October 10, 2025 14:29
@tim-schilling tim-schilling marked this pull request as ready for review October 10, 2025 14:29
@tim-schilling
Copy link
Member

I've rebased on main, fixed the pre-commit errors due to doc8 (the lines were too long), and reverted my suggestion of combining the open commands for OSes.

I'm going to squash these commits and merge.

@tim-schilling tim-schilling merged commit e2e7242 into django-commons:main Oct 10, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contributing documentation on how to generate docs locally

3 participants