HTML characters breaks HtmlParser

[camilonova]

Trying to compress a line like this one:

var html = "<//div>"

Raise this error:

Error while initializing HtmlParser: bad end tag: u'<//div>', at line 28, column 47

Seems to happen with any html closing tag.

This is likely an HtlmParser error and maybe should it be removed from the parsers, BeautifulSoup works fine.

Using this setting:

COMPRESS_PARSER = 'compressor.parser.AutoSelectParser'

fails silently, but using 'HtmlParser' shows the error.

NOTE: installing lxml is a pain in the ass :(

[jaap3]

This is somewhat of an edge case. {% compress %} blocks are usually only wrapped around the lines needing compression, as far as I know it actually "eats" all non CSS/JS related HTML.

If you really need to be able to compress CSS/JS in malformed HTML (and you are unable to fix the template for some reason) you'll indeed need to change your parser to the much heavier BeautifulSoup. In most cases the 'dumb' HtmlParser works just fine.

[camilonova]

Not always, if you try to compress clean html, not malformed, it breaks too, and it usually the use of html templating using javascript is getting more used this days.

Besides, why the compressor cant handle simple html? otherwise, will be a better option not to try compress html inside javascript??

[bendavis78]

Same thing happens with me exactly as camilonova said. Even of you have clean html inside of a string, it breaks, and ends up truncating the javascript file at that point, leading to mysterious javascript errors.

[jaap3]

Could you try wrapping the javascript in a html comment? so:
<script><!-- alert('javascript'); //--></script>

I'm currently unable to try this myself, but it might work...If not you could try swapping the parser to a more robust, but slower one:
COMPRESS_PARSER = 'compressor.parser.BeautifulSoupParser'

[jezdez]

So while I'm not sure if this can be fixed for good, it'd be good to at least warn users of the behavior and explain to use a different parser instead. What do you think?

[camilonova]

I think a warn is just good.

[jedie]

This problem has other guys, too: gregmuellegger/django#1

The real problem is here: http://bugs.python.org/issue670664 and has pachtes...

EDIT: I tried http://bugs.python.org/file22767/hp_fix.diff from http://bugs.python.org/issue670664 and this seems to fix this issues!

I add the patch in my django-tools with: jedie/django-tools@aa722b3 django-compressor can do this, too.