Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make CssAbsoluteFilter replace src="..." patterns with absolute paths #126

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jonasvp commented Sep 26, 2011

The workarounds for many CSS3 properties in IE use proprietary "Filter" expressions. These often need a "src" variable with an image path. For some reason, that path is interpreted as relative to the HTML file
including the CSS, not the CSS file itself.

The second commit in this pull request makes those paths absolute as well. The first commit just adds a missing import.

Let me know if this is something likely to be merged, in that case I'll add some tests.

jonasvp added some commits Sep 26, 2011

Make CssAbsoluteFilter replace src="..." patterns with absolute paths
The workarounds for many CSS3 properties in IE use proprietary "Filter"
expressions. These often need a "src" variable with an image path. For
some reason, that path is intepreted as relative to the HTML file
including the CSS, not the CSS file itself.

This patch makes those paths absolute as well.
Owner

jezdez commented Sep 26, 2011

Yes, this needs tests.

jonasvp added a commit to jonasvp/django_compressor that referenced this pull request Feb 8, 2012

@jonasvp jonasvp closed this Feb 8, 2012

Contributor

jonasvp commented Feb 8, 2012

Whoops, something went wrong here. This one should be mergeable: jezdez#208

jezdez pushed a commit that referenced this pull request Feb 8, 2012

Merge pull request #208 from jonasvp/issue_126
New pull request for Issue #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment