Precompiler class support (cleaned & tests fixed) #313

Merged
merged 8 commits into from Sep 13, 2012

Conversation

Projects
None yet
4 participants
Contributor

anttihirvonen commented Sep 13, 2012

This is based on pull requests #291 and #236. I cherry-picked the commits, fixed the tests and removed DustFilter that @ulyssesv introduced, as I think that the per-type precompiler classes shouldn't be in the django-compressor core. They should be developed as their own packages, or JST-precompiler should be implemented as a class that can support any Javascript templating engine. Django-pipeline already has a support for this (http://django-pipeline.readthedocs.org/en/latest/templates.html).

Any feedback would be greatly appreciated!

Contributor

ulyssesv commented Sep 13, 2012

+1

jezdez merged commit 8279b90 into django-compressor:develop Sep 13, 2012

1 check failed

default The Travis build failed
Details
Contributor

matthewwithanm commented on 09dc849 Oct 3, 2012

Isn't it a little weird that the __init__ signatures of custom precompiler classes don't match FilterBase's?

Contributor

ulyssesv commented Oct 6, 2012

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment