Use environment variable DJANGO_SETTINGS_MODULE. #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per comment on #333, the relevant place for this looks to be django-compressor/django-appconf#13. We should close this in favour of a resolution there. |
|
Closing per previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After encountering a problem I found in some issues (fixes #333, fixes #273), I decided to make some investigation. The suggestion made by @panosmm (#333 (comment)) seemed fine to me, but then I went in the django-appconf documentation, and found the following:
"In case you want to use a different settings object instead of the default 'django.conf.settings', set the holder attribute of the inner Meta class to a dotted import path."
Thus, I think django-compressor should use this holder attribute. I made this PR, allowing django-compressor to use the DJANGO_SETTINGS_MODULE defined in our projects.