Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

test translation fix #30

Merged
merged 2 commits into from Apr 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

gaftech commented Mar 22, 2012

The test_crispy_tag_with_helper_form_show_errors (crispy_forms/tests/test.py, line 199) test fails if language is not english. When rendering template, "This field is required" is translated, so it should be tested against the translated version.

Collaborator

maraujop commented Mar 25, 2012

Thanks @gaftech

You are right, could you please update your pull request, so that all "This field is required" get translated, I believe you are missing another match.

Cheers

Contributor

gaftech commented Mar 25, 2012

Done !

@maraujop maraujop merged commit 0e3b35e into django-crispy-forms:dev Apr 3, 2012

Collaborator

maraujop commented Apr 3, 2012

Thanks @gaftech ! I just merged your fix in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment