Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass node context through to template via crispy tag #579

Merged
merged 1 commit into from Apr 18, 2016
Merged

Pass node context through to template via crispy tag #579

merged 1 commit into from Apr 18, 2016

Conversation

lskillen
Copy link
Contributor

@lskillen lskillen commented Apr 15, 2016

First of all, the pleasantries because this is a first PR: django-crispy-forms is certified awesome (flattery gets you everywhere). 馃憤

This PR adds passing of the origin context through to the context used when rendering forms/fields/etc., such that they can be customised via templates (if desired). Any context that comes from the helper takes precedence over that which is implicitly carried from templates.

Just to make sure it was actually working I added a test within test_layout.py, although I didn't feel like this was the best place to put, there was no-where else that fit exactly either. If there any issues or concerns, or if additional requests are required, I'd be happy to help out.

Cheers!

Closes #436

@codecov-io
Copy link

Current coverage is 96.35%

Merging #579 into dev will increase coverage by +0.01% as of e818cdb

@@              dev    #579   diff @@
=====================================
  Files          24      24       
  Stmts        2490    2499     +9
  Branches      224     224       
  Methods         0       0       
=====================================
+ Hit          2399    2408     +9
  Partial        45      45       
  Missed         46      46       

Review entire Coverage Diff as of e818cdb

Powered by Codecov. Updated on successful CI builds.

@carltongibson carltongibson added this to the 1.6.0 milestone Apr 18, 2016
@carltongibson
Copy link
Collaborator

Yep. Nice. Thanks for PR!

@carltongibson carltongibson merged commit ad39cdd into django-crispy-forms:dev Apr 18, 2016
carltongibson pushed a commit that referenced this pull request Apr 20, 2016
Add to contributors for PR #579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants