Skip to content

Loading…

Refresh dependencies and split requirements.txt between dev and production #24

Merged
merged 3 commits into from

2 participants

@dplanella

While installing Cab, I noticed that there was a missing dependency on Whoosh (for django-haystack) on the requirements.txt file.

It turns out that this dependency is only required in a development environment, so as suggested on the discussion thread, I ended up splitting the requirements files for development/production.

@zerok
Deutscher Django-Verein e.V. member

Whoosh is not necessarily a dependency since we only use it in the development environment. djangosnippets itself IIRC uses SOLR. We should probably split up the requirements.txt to make this more apparent :-)

@dplanella

@zerok ok, I've finally had some time to look into this and I've implemented your suggestion of splitting the development and production requirements.txt file. Let me know what you think.

@dplanella

Looking at it in more detail, is there a particular reason to use an old snapshot of django-storages (https://bitbucket.org/jezdez/django-storages/get/f312d8bc7520.zip) instead of a newer, standard release?

@zerok
Deutscher Django-Verein e.V. member

Sorry for the delay and thank your work on this one :-)

AFAIK keeping current with django-storages should be fine. I will look over it and ideally merge it someone today.

@zerok zerok merged commit 7e5b646 into django-de:master
@dplanella

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Showing with 20 additions and 19 deletions.
  1. +10 −0 requirements-common.txt
  2. +2 −0 requirements-dev.txt
  3. +8 −19 requirements.txt
View
10 requirements-common.txt
@@ -0,0 +1,10 @@
+Django==1.4.4
+Markdown==2.2.1
+Pygments==1.6
+South==0.7.5
+django-generic-aggregation==0.3.1
+django-simple-ratings==0.3.2
+django-haystack==1.2.7
+django-pagination==1.0.7
+django-registration==0.8
+django-taggit==0.9.3
View
2 requirements-dev.txt
@@ -0,0 +1,2 @@
+-r requirements-common.txt
+Whoosh==2.4.1
View
27 requirements.txt
@@ -1,23 +1,12 @@
-Django==1.4.4
-Markdown==2.2.1
-Pygments==1.6
-South==0.7.5
-django-generic-aggregation==0.3.1
-django-simple-ratings==0.3.2
-django-haystack==1.2.7
-django-pagination==1.0.7
-django-registration==0.8
-django-taggit==0.9.3
-django-redis-cache==0.9.6
-pysolr==2.1.0-beta
+-r requirements-common.txt
gunicorn==0.17.2
-dj-database-url==0.2.1
psycopg2==2.4.6
-gevent==0.13.8
-raven==1.9.4
-BeautifulSoup==3.2.1
-hiredis>=0.1.1
+pysolr==2.1.0-beta
django-postgrespool==0.2.4
-# django-storages==1.1.5
-https://bitbucket.org/jezdez/django-storages/get/f312d8bc7520.zip
+django-redis-cache==0.9.6
+raven==1.9.4
+django-storages>=1.1.6
boto==2.8.0
+gevent==0.13.8
+hiredis>=0.1.1
+dj-database-url==0.2.1
Something went wrong with that request. Please try again.