Skip to content

Include django.contrib in the stacktraces #505

Open
apollo13 opened this Issue Dec 21, 2013 · 3 comments

3 participants

@apollo13

As a followup to #504 I think it would be a good idea to show traces for django.contrib. list_display is one of the usual offenders which can easily cause quite a few queries which is relatively hard to debug for newcomers -- having a trace would certainly help.

@aaugustin

This used to be the case before 03fd1cc.

@tim-schilling

It looks like there's a comment that still mentions that contrib should show up. The first two options I see are, 1) add some logic to utils.tidy_stacktrace that allows django.contrib to be included, the other would be to change the setting HIDE_IN_STACKTRACE to include all modules of django except for django.contrib.

@aaugustin

That patch works but it's a bit messy. I would like to look for other ideas before making a decision.

Maybe we need a more thorough refactoring of this feature. By the way, I'm wondering how the current implementation fares with namespace packages, whose bits can live in various directories — probably not well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.