Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

JavaScript Tests Needed #539

Open
carltongibson opened this Issue · 3 comments

3 participants

@carltongibson

DDT has a fair bit of JavaScript. Some test coverage would help avoid regressions.

First task is to decide on a test framework. Any suggestions?*

I'd say it should run in the browser and be compatible with Travis. I need to have a look around; does such a thing even exist. QUnit comes to mind for the first, no doubt there are others*

*Cue Holy War.

@aaugustin
Owner

Whoever writes the 10 first tests get to choose the framework :)

I suspect we'll need to refactor the JS before we can really test it.

@tim-schilling

I decided to write the javascript tests before redo-ing any of the API as a way of regression testing the application. https://github.com/tim-schilling/django-debug-toolbar/tree/javascript-tests

I choose to go with selenium as it should be easy to integrate with SauceLabs and Travis.

I'll probably refactor the logic a bit before submitting the PR, but wanted to solicit feedback.

@aaugustin
Owner

This looks good, don't forget to add the manual in docs/contributing.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.