Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading templates setting after django 1.8 #948

Merged
merged 2 commits into from Aug 29, 2016

Conversation

Projects
None yet
3 participants
@albertyw
Copy link
Contributor

commented Aug 28, 2016

This replaces code that directly reads TEMPLATE_DIRS with a function that can read either that setting or the newer TEMPLATES setting.

Fixes #942

@albertyw albertyw force-pushed the albertyw:update-template-setting branch 3 times, most recently from 1cee2dd to a558473 Aug 28, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2016

Coverage Status

Coverage increased (+0.1%) to 36.3% when pulling a558473 on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@albertyw albertyw force-pushed the albertyw:update-template-setting branch 3 times, most recently from ba342b9 to b36b48e Aug 28, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2016

Coverage Status

Coverage increased (+0.1%) to 36.3% when pulling b36b48e on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@albertyw albertyw force-pushed the albertyw:update-template-setting branch from b36b48e to 0312573 Aug 28, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2016

Coverage Status

Coverage increased (+0.1%) to 36.3% when pulling 0312573 on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@albertyw albertyw force-pushed the albertyw:update-template-setting branch from 0312573 to fabf727 Aug 28, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2016

Coverage Status

Coverage increased (+0.1%) to 36.3% when pulling fabf727 on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@trbs

This comment has been minimized.

Copy link
Member

commented Aug 28, 2016

Could you please move the code for reading pre/post Django 1.8 TEMPLATE settings to django_extensions/compat.py ?

@trbs trbs added the bug label Aug 28, 2016

@albertyw albertyw force-pushed the albertyw:update-template-setting branch from fabf727 to c817bb0 Aug 28, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2016

Coverage Status

Coverage increased (+0.1%) to 36.311% when pulling c817bb0 on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@albertyw albertyw force-pushed the albertyw:update-template-setting branch from c817bb0 to 9ee4092 Aug 29, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 29, 2016

Coverage Status

Coverage increased (+0.1%) to 36.311% when pulling 9ee4092 on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@albertyw albertyw force-pushed the albertyw:update-template-setting branch from 9ee4092 to c39f5de Aug 29, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 29, 2016

Coverage Status

Coverage increased (+0.1%) to 36.311% when pulling c39f5de on albertyw:update-template-setting into ff6a574 on django-extensions:master.

@trbs trbs merged commit 925ef0b into django-extensions:master Aug 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trbs

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

Thanks !

@albertyw albertyw referenced this pull request Sep 6, 2016

Closed

Release new version #958

@albertyw albertyw deleted the albertyw:update-template-setting branch Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.