Incompatible with django-mptt 0.5-pre #38

Closed
ghughes opened this Issue Oct 24, 2011 · 3 comments

Comments

Projects
None yet
2 participants

ghughes commented Oct 24, 2011

The folks over at django-mptt have just committed a backwards incompatible change: the TreeManager on an MPTTModel can no longer be accessed using the .tree attr; instead, TreeManager is now the default manager, accessible via .objects. I think an easy fix is to add tree = TreeManager() to the Page model. This will ensure that fiber remains compatible with 0.4.2 and 0.5 (which is due for release soon).

ghughes commented Oct 24, 2011

This is the commit I'm referring to: django-mptt/django-mptt@1651bf7

@ghughes ghughes added a commit to ghughes/django-fiber that referenced this issue Oct 24, 2011

@ghughes ghughes add explicit TreeManager to Page model - fixes #38 19bd54b

ghughes commented Oct 24, 2011

Please disregard above commit, it doesn't actually fix the issue; it seems that django-mptt's new behaviour is to overwrite .objects with a TreeManager, even if you add tree = TreeManager() to your model. I have raised this issue on the django-mptt repo and hope to commit a fixed patch shortly.

ghughes commented Oct 28, 2011

OK, the above commit 19bd54b does solve the issue with the just-released django-mptt 0.5. Please pull.

mvdwaeter closed this Nov 8, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment