New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init rus taxation policy, base template #7

Merged
merged 10 commits into from Nov 18, 2012

Conversation

Projects
None yet
2 participants
@suvit
Contributor

suvit commented Nov 13, 2012

added initial russian taxation policy
added base template for all templates (for easy extends from project base template)
added pytz to requirements
move euro taxation policy to separate file.

TODO UserPlanMiddleware catch user at each request (but AuthMiddleware not, it was used SimpleLazyObject). I fixed this in near future (Why needed this middleware???)

Why is required user_plan of every user?

suvit added some commits Nov 12, 2012

added first russian taxation policy
remove import suds vatnumber from abstract class
added conf.py (TODO use django_conf for default settings)
added base template
extends all template from base
added empty (yet) create_order template
@suvit

This comment has been minimized.

Show comment
Hide comment
@suvit

suvit Nov 13, 2012

Contributor

templates missing

  • plans/order_create.html
  • plans/account_activation.html
Contributor

suvit commented Nov 13, 2012

templates missing

  • plans/order_create.html
  • plans/account_activation.html
@suvit

This comment has been minimized.

Show comment
Hide comment
@suvit

suvit Nov 13, 2012

Contributor

Update
added requirement extra eu
you may installs extra packages by pip install django-plans[eu]

Contributor

suvit commented Nov 13, 2012

Update
added requirement extra eu
you may installs extra packages by pip install django-plans[eu]

@cypreess

This comment has been minimized.

Show comment
Hide comment
@cypreess

cypreess Nov 13, 2012

Collaborator

That is excelent pice of work. I will merge it as soon as I will have a spare time.

Answers:
"Why is required user_plan of every user?"
That was stupid assumption made on start that every account will be considered for plan expiration. The better assumption is that User that have user_plan defined is obligated to restricted quota and account expiration, and without user_plan - this account is like "unlimited for everything". But this is big change that will possibly break compatibility in few places - so it should checked carefully.

"Why needed this middleware???"
I thought that if everyuser is so strictlu connected with plan - for convienence plan&quotas should be accessible from every request object (like a user is). But now I don't think that this is good idea anymore.

Collaborator

cypreess commented Nov 13, 2012

That is excelent pice of work. I will merge it as soon as I will have a spare time.

Answers:
"Why is required user_plan of every user?"
That was stupid assumption made on start that every account will be considered for plan expiration. The better assumption is that User that have user_plan defined is obligated to restricted quota and account expiration, and without user_plan - this account is like "unlimited for everything". But this is big change that will possibly break compatibility in few places - so it should checked carefully.

"Why needed this middleware???"
I thought that if everyuser is so strictlu connected with plan - for convienence plan&quotas should be accessible from every request object (like a user is). But now I don't think that this is good idea anymore.

@suvit

This comment has been minimized.

Show comment
Hide comment
@suvit

suvit Nov 14, 2012

Contributor

Now installer downloads right suds package.
But django-transmeta and django-ordered-model doesn`t isntalled by default

Contributor

suvit commented Nov 14, 2012

Now installer downloads right suds package.
But django-transmeta and django-ordered-model doesn`t isntalled by default

@cypreess cypreess merged commit 9359844 into django-getpaid:master Nov 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment