Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

from_python was also removed from pyelasticsearch #762

Closed
robertour opened this Issue Mar 28, 2013 · 4 comments

Comments

Projects
None yet
2 participants

The method from_python was removed from ElasticSearch in pyelasticsearch, in this commit. But it is still being called at least in elasticsearch_backend.py line 758. The function is called 9 times in this file but I am not sure if all of them are related to pyelasticsearch.

This is related to this issue:
to_python is not defined in the new pyelasticsearch toastdriven#758

And this pull request:
Pyelasticsearch 0.4 compatibility (fairly urgent) toastdriven#759

mpetyx commented Apr 3, 2013

what is the status of this?
currently i cannot make pyelasticsearch work on my server and it is getting pretty inconvenient.
please any help would be more than welcome.
thank you!

mpetyx commented Apr 3, 2013

actually, to fix it on my platform i created a small fix
mpetyx/pyelasticsearch@fc9e71d#pyelasticsearch/client.py
reverting the old "from_python", for anyone who might need it.
cheers

@jezdez jezdez closed this in 5409197 Apr 3, 2013

mpetyx commented Apr 3, 2013

nice fix. thank you!

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment