Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Scalable update index #1517
referenced this pull request
Jun 9, 2017
This looks good to me. The only thing I wanted to check first was confirming that this code is exercised in a testcase which has a non-numeric PK so we can avoid a possible regression for the people using things like UUIDs.
Apologies. The mockuuidmodel is not actually used yet. I'm going to get it fixed in my next PR to address #1543 . I have had a lot of real life calamity and chaos this last week so I didn't get to finish it. Will work on it as soon as real life stuff calms down.
I've just created a PR #1551 to address Issue #1543 which also implements UUIDMockModel testing with a variety of tests. Hopefully this will provide coverage here. I changed the name of the uuid model to fit naming conventions with the rest of the stuff I see.
When the PR gets accepted I would ask that you quickly rebase and run the tests through travis. Or simply re-trigger a test build on this PR in travis.