New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distance sort hardcoded index #1522

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@cristiano2lopes

cristiano2lopes commented Jun 20, 2017

Fix for #1195. Added a test to reproduce the issue but unfortunately I'am having ES ClassCastExceptions and can't dedicate more time for now. The test should reproduce the error and I'am already using the fix via a fork.

@acdha

This comment has been minimized.

Show comment
Hide comment
@acdha

acdha Jul 7, 2017

Contributor

Try rebasing this branch against master now that #1530 fixed the ES Travis build issues.

Contributor

acdha commented Jul 7, 2017

Try rebasing this branch against master now that #1530 fixed the ES Travis build issues.

cristiano2lopes added some commits Jun 20, 2017

Carry the index of _geo_distance sort key, to allow _process_results …
…to correctly

extract the distance

Fix for #1195
@cristiano2lopes

This comment has been minimized.

Show comment
Hide comment
@cristiano2lopes

cristiano2lopes commented Jul 7, 2017

@acdha Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment