New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv setup_requires to install requires #1603

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Friday21

Friday21 commented Apr 23, 2018

according to this issue and this one, when install pypi with my custom pypi, it will raise DistutilsError, because my server can't access https://pypi.org/simple/, because setuptools uses it's own logic to find the distributions mentioned in setup_requires. And, that logic is unable to fetch the distribution. so I move it to install_requires.

@aerostitch

This comment has been minimized.

Show comment
Hide comment
@aerostitch

aerostitch Apr 29, 2018

To be fair, I think you don't need setuptools_scm in install_requires but pkg_resources.
moving the entire setuptools_scm does the trick because it depends on pkg_resources but it might be overkill to bring setuptools_scm just because you require pkg_resources, don't you think?

Note that pkg_resources is part of setuptools, so you might just need a dependency on setuptools.

I believe it would fix 2 RC bugs we have in Debian: https://bugs.debian.org/896296 and https://bugs.debian.org/896263
Thanks! :)

aerostitch commented Apr 29, 2018

To be fair, I think you don't need setuptools_scm in install_requires but pkg_resources.
moving the entire setuptools_scm does the trick because it depends on pkg_resources but it might be overkill to bring setuptools_scm just because you require pkg_resources, don't you think?

Note that pkg_resources is part of setuptools, so you might just need a dependency on setuptools.

I believe it would fix 2 RC bugs we have in Debian: https://bugs.debian.org/896296 and https://bugs.debian.org/896263
Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment