-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request handler #134
Request handler #134
Conversation
I've rebased this onto toastdriven/master. |
a14ebba
to
b3d161d
Compare
b3d161d
to
a62ec3e
Compare
Rebased onto current master. |
The following test run fails:
During all of the tests in this run, no connection can be established to SOLR. This works in all the other test runs. It might be a one time thing?
I assume this means that my tests are fine, all over, seeing that all of the other runs finish just fine. |
@acdha Thanks for checking! I hope everything is fine with my rebase and you are fine merging it. |
rebased - again! Please consider merging this? |
This is a pull request that contains and replaces #112 , addressing #51 and #52 :
Additionally to specifying request handlers at the method level, it allows to specify a
search_handler
as instance variable. Also, a new instance variableuse_qt_param
is available that allows to change how request handlers are specified in the SOLR URL. The default SOLR behavior is to expect the handler as URL path variable (current #112 implementation). The pre 3.6 default behavior (and still available via configuration) specifies the request handler viaqt
parameter in the URL.This pull request will allow to specify a custom request handler at construction time and thus allow to configure it as data source for Haystack like this:
Update README to include documentation of custom handlers.
I had to change the import statement in
get-solr-download-url.py
to make the tests run. (Using 3.4 but actually my fix should be for python3 in general.)