Fix rich content extraction method & tests #63

Merged
merged 1 commit into from Jan 24, 2013

Conversation

Projects
None yet
2 participants
Collaborator

acdha commented Jan 23, 2013

  • Update test setup instructions with content extraction handler dependencies
  • Enable file upload support to _send_request
  • Added extraction tests

One side note: the change to the otherwise unrelated log_body handling in _send_request makes me think we should stop doing that and simply pass extra data to logging so things which are prepared to format the bodies can do so without _send_request having to do as much string processing.

@acdha acdha Fix rich content extraction method & tests
* Update test setup instructions with content extraction handler
  dependencies
* Enable file upload support to _send_request
* Added simple extract test
e22d7d1
Collaborator

toastdriven commented Jan 24, 2013

Looks great! :shipit: & preferably roll a v3.0.2 release.

log_body was only added to prevent mixing bytestrings & Unicode in the logging messages. I'm good with whatever reduces that pain.

Collaborator

acdha commented Jan 24, 2013

I'll defer log_body changes now – let's discuss logging with other users (#haystack?) to make sure I'm not pushing too far into Sentry-specific behaviour

@acdha acdha merged commit e22d7d1 into django-haystack:master Jan 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment