From 44bbcd31e56687aa04b8df6d361ba2d3cee02d4a Mon Sep 17 00:00:00 2001 From: Daryl Date: Thu, 30 Jun 2016 11:56:27 +1200 Subject: [PATCH] Bug in test_per_queue_staff_permission.py Using the django auth backend allows integers to be passed as a password Using Peter Sagerson's ldap auth backend there is an error thrown because some code tries to do a len() on the password. You could argue that the ldap auth backend should str(password), but you could also argue that passing an int as a password is bad practice This PR ensures that a string is sent to the auth module. --- helpdesk/tests/test_per_queue_staff_permission.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helpdesk/tests/test_per_queue_staff_permission.py b/helpdesk/tests/test_per_queue_staff_permission.py index 8362307a1..7ac144805 100644 --- a/helpdesk/tests/test_per_queue_staff_permission.py +++ b/helpdesk/tests/test_per_queue_staff_permission.py @@ -41,7 +41,7 @@ def setUp(self): username='User_%d' % identifier, is_staff=True, ) - user.set_password(identifier) + user.set_password(str(identifier)) user.save() # The prefix 'helpdesk.' must be trimmed @@ -74,7 +74,7 @@ def test_dashboard_ticket_counts(self): # Regular users for identifier in self.IDENTIFIERS: - self.client.login(username='User_%d' % identifier, password=identifier) + self.client.login(username='User_%d' % identifier, password=str(identifier)) response = self.client.get(reverse('helpdesk_dashboard')) self.assertEqual( len(response.context['unassigned_tickets']), @@ -131,7 +131,7 @@ def test_ticket_list_per_queue_user_restrictions(self): """ # Regular users for identifier in self.IDENTIFIERS: - self.client.login(username='User_%d' % identifier, password=identifier) + self.client.login(username='User_%d' % identifier, password=str(identifier)) response = self.client.get(reverse('helpdesk_list')) self.assertEqual( len(response.context['tickets']), @@ -166,7 +166,7 @@ def test_ticket_reports_per_queue_user_restrictions(self): """ # Regular users for identifier in self.IDENTIFIERS: - self.client.login(username='User_%d' % identifier, password=identifier) + self.client.login(username='User_%d' % identifier, password=str(identifier)) response = self.client.get( reverse('helpdesk_run_report', kwargs={'report': 'userqueue'}) )