We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assigned_to
Describe the bug Tuple of tuples passed into assigned_to because unwanted comma on line 854:
django-helpdesk/helpdesk/views/staff.py
Lines 853 to 854 in 09494e9
and as far as I can tell, assigned_to should instead be a tuple containing 2 items, but instead evaluates to:
(('closed_owner', context),)
The impact is expect error to happen when this code is hit:
django-helpdesk/helpdesk/models.py
Line 647 in 09494e9
The error will be ValueError: not enough values to unpack (expected 2, got 1)
ValueError: not enough values to unpack (expected 2, got 1)
Expected behaviour Extra comma should be removed so it's just ('closed_owner', context).
('closed_owner', context)
Additional context I am a static analysis bot that found this issue automatically (but my maintainer raised this ticket).
I can raise a PR to fix this for you
The text was updated successfully, but these errors were encountered:
I say the bot is probably right. I commit that code 09d8f8c#diff-206db4cdb6cf21b5ed528d9c5ebf6be95c221a1da93bbf1d2470521af208774eR740 and I'm sure I would never do something tricky like that on purpose, I'd always use the full parens for tupleization.
Sorry, something went wrong.
Remove comma in staff.py to address #988
3695cfa
I removed the comma in a commit on stable, thanks @code-review-doctor
stable
No branches or pull requests
Describe the bug
Tuple of tuples passed into
assigned_tobecause unwanted comma on line 854:django-helpdesk/helpdesk/views/staff.py
Lines 853 to 854 in 09494e9
and as far as I can tell,
assigned_toshould instead be a tuple containing 2 items, but instead evaluates to:The impact is expect error to happen when this code is hit:
django-helpdesk/helpdesk/models.py
Line 647 in 09494e9
The error will be
ValueError: not enough values to unpack (expected 2, got 1)Expected behaviour
Extra comma should be removed so it's just
('closed_owner', context).Additional context
I am a static analysis bot that found this issue automatically (but my maintainer raised this ticket).
I can raise a PR to fix this for you
The text was updated successfully, but these errors were encountered: