Sanity checks against input for ticket search #108

Merged
merged 3 commits into from Jan 23, 2012

Conversation

Projects
None yet
3 participants
@ivgiuliani
Contributor

ivgiuliani commented Jan 17, 2012

Currently input parameters within the ticket search view are not validated, thus (manually) altering the parameters in the query string issues a 500. This patch attempts to solve this problem, reverting to the default query when the situation can't be recovered.

Sanity checks against input for ticket search
Currently input parameters within the ticket search view are not
validated, thus (manually) altering the parameters in the query string
issues a 500. This patch attempts to solve this problem, reverting to
the default query when the situation can't be recovered.
@vovkd

This comment has been minimized.

Show comment Hide comment
@vovkd

vovkd Jan 17, 2012

this pull request relates to my issue post rossp#107

vovkd commented Jan 17, 2012

this pull request relates to my issue post rossp#107

apply_query shouldn't modify the parameters dictionary
Changing parameters in apply_query might yield an invalid state in later
code that assumes the query was not changed.
This patch avoids parameters modification and should fix the issue
reported in #109

rossp added a commit that referenced this pull request Jan 23, 2012

Merge pull request #108 from kratorius/fix-query-filtering
Sanity checks against input for ticket search

@rossp rossp merged commit 230f94f into django-helpdesk:master Jan 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment