New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for tracking time spent on tickets and follow-ups #717

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@jachym
Copy link
Contributor

jachym commented Feb 6, 2019

Adding basic support for tracking spend time on tickets.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #717 into develop will decrease coverage by <.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #717      +/-   ##
===========================================
- Coverage    69.58%   69.57%   -0.01%     
===========================================
  Files           42       42              
  Lines         4083     4099      +16     
  Branches       500      504       +4     
===========================================
+ Hits          2841     2852      +11     
- Misses        1099     1102       +3     
- Partials       143      145       +2
Impacted Files Coverage Δ
helpdesk/views/staff.py 44.39% <ø> (ø) ⬆️
helpdesk/models.py 79.24% <71.42%> (-0.23%) ⬇️
helpdesk/admin.py 85.45% <75%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e094...43948c7. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #717 into develop will decrease coverage by <.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #717      +/-   ##
===========================================
- Coverage    69.58%   69.57%   -0.01%     
===========================================
  Files           42       42              
  Lines         4083     4099      +16     
  Branches       500      504       +4     
===========================================
+ Hits          2841     2852      +11     
- Misses        1099     1102       +3     
- Partials       143      145       +2
Impacted Files Coverage Δ
helpdesk/views/staff.py 44.39% <ø> (ø) ⬆️
helpdesk/models.py 79.24% <71.42%> (-0.23%) ⬇️
helpdesk/admin.py 85.45% <75%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e094...43948c7. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #717 into develop will decrease coverage by <.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #717      +/-   ##
===========================================
- Coverage    69.58%   69.57%   -0.01%     
===========================================
  Files           42       42              
  Lines         4083     4099      +16     
  Branches       500      504       +4     
===========================================
+ Hits          2841     2852      +11     
- Misses        1099     1102       +3     
- Partials       143      145       +2
Impacted Files Coverage Δ
helpdesk/views/staff.py 44.39% <ø> (ø) ⬆️
helpdesk/models.py 79.24% <71.42%> (-0.23%) ⬇️
helpdesk/admin.py 85.45% <75%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e094...6ceb89a. Read the comment docs.

@timthelion

This comment has been minimized.

Copy link

timthelion commented Feb 6, 2019

Linguistically would have been better to use the phrase "Time spent" rather than "Time spend" but other than that it is a pretty simple change.

@jachym

This comment has been minimized.

Copy link
Contributor Author

jachym commented Feb 6, 2019

will continue on this pr, and will fix this, thanks for pointing me at it

@gwasser

This comment has been minimized.

Copy link
Member

gwasser commented Feb 6, 2019

Sounds good! I agree "time spent" sounds better to me. Let me know when you're ready for a review and pull.

@gwasser gwasser added this to the 0.3 milestone Feb 6, 2019

@jachym jachym force-pushed the OpenGeoLabs:time_tracking branch from 43948c7 to d99f5a0 Feb 6, 2019

@jachym

This comment has been minimized.

Copy link
Contributor Author

jachym commented Feb 6, 2019

I have 2 issues:

  1. I'm probably not able to implement any reasonable reports right now
  2. Not sure, how to render proper time i the list of tickets. Serializer seems to support DurationField but the result is number of seconds (no really readable).

Otherwise, I do not have much to be added right now.

@jachym jachym force-pushed the OpenGeoLabs:time_tracking branch from d99f5a0 to a62c044 Feb 6, 2019

@gwasser gwasser changed the title Tbasic support for time spend of tikets and follow-ups Basic support for tracking time spent on tickets and follow-ups Feb 6, 2019

@jachym jachym force-pushed the OpenGeoLabs:time_tracking branch from a62c044 to 6ceb89a Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment