More tests for RelationshipView

Author: jsenecal

example/models.py

@@ -54,7 +54,11 @@ def __str__(self):
 class Comment(BaseModel):
     entry = models.ForeignKey(Entry)
     body = models.TextField()
-    author = models.ForeignKey(Author)
+    author = models.ForeignKey(
+        Author,
+        null=True,
+        blank=True
+    )
 
     def __str__(self):
         return self.body

example/tests/test_views.py

@@ -1,51 +1,82 @@
+import json
+
 from django.utils import timezone
 from rest_framework.reverse import reverse
-from rest_framework.test import APITestCase, APIRequestFactory
-import json
 
-from rest_framework_json_api.utils import format_relation_name
+from rest_framework.test import APITestCase
 
-from example.models import Blog, Entry
-from example.views import EntryRelationshipView, BlogRelationshipView
+from rest_framework_json_api.utils import format_relation_name
+from example.models import Blog, Entry, Comment, Author
 
 
 class TestRelationshipView(APITestCase):
     def setUp(self):
+        self.author = Author.objects.create(name='Super powerful superhero', email='i.am@lost.com')
         self.blog = Blog.objects.create(name='Some Blog', tagline="It's a blog")
         self.other_blog = Blog.objects.create(name='Other blog', tagline="It's another blog")
-        self.entry = Entry.objects.create(
+        self.first_entry = Entry.objects.create(
             blog=self.blog,
-            headline='headline',
-            body_text='body_text',
+            headline='headline one',
+            body_text='body_text two',
             pub_date=timezone.now(),
             mod_date=timezone.now(),
             n_comments=0,
             n_pingbacks=0,
             rating=3
         )
+        self.second_entry = Entry.objects.create(
+            blog=self.blog,
+            headline='headline two',
+            body_text='body_text one',
+            pub_date=timezone.now(),
+            mod_date=timezone.now(),
+            n_comments=0,
+            n_pingbacks=0,
+            rating=1
+        )
+        self.first_comment = Comment.objects.create(entry=self.first_entry, body="This entry is cool", author=None)
+        self.second_comment = Comment.objects.create(
+            entry=self.second_entry,
+            body="This entry is not cool",
+            author=self.author
+        )
 
     def test_get_entry_relationship_blog(self):
-        url = reverse('entry-relationships', kwargs={'pk': self.entry.id, 'related_field': 'blog'})
+        url = reverse('entry-relationships', kwargs={'pk': self.first_entry.id, 'related_field': 'blog'})
         response = self.client.get(url)
-        expected_data = {'type': format_relation_name('Blog'), 'id': str(self.entry.blog.id)}
+        expected_data = {'type': format_relation_name('Blog'), 'id': str(self.first_entry.blog.id)}
 
         assert response.data == expected_data
 
     def test_get_entry_relationship_invalid_field(self):
-        response = self.client.get('/entries/{}/relationships/invalid_field'.format(self.entry.id))
+        response = self.client.get('/entries/{}/relationships/invalid_field'.format(self.first_entry.id))
 
         assert response.status_code == 404
 
     def test_get_blog_relationship_entry_set(self):
         response = self.client.get('/blogs/{}/relationships/entry_set'.format(self.blog.id))
 
     def test_put_entry_relationship_blog_returns_405(self):
-        url = '/entries/{}/relationships/blog'.format(self.entry.id)
+        url = '/entries/{}/relationships/blog'.format(self.first_entry.id)
         response = self.client.put(url, data={})
         assert response.status_code == 405
 
+    def test_patch_invalid_entry_relationship_blog_returns_400(self):
+        url = '/entries/{}/relationships/blog'.format(self.first_entry.id)
+        response = self.client.patch(url,
+                                     data=json.dumps({'data': {'invalid': ''}}),
+                                     content_type='application/vnd.api+json')
+        assert response.status_code == 400
+
+    def test_get_empty_to_one_relationship(self):
+        url = '/comments/{}/relationships/author'.format(self.first_entry.id)
+        response = self.client.get(url)
+        expected_data = None
+
+        assert response.data == expected_data
+
     def test_patch_to_one_relationship(self):
-        url = '/entries/{}/relationships/blog'.format(self.entry.id)
+        url = '/entries/{}/relationships/blog'.format(self.first_entry.id)
         request_data = {
             'data': {'type': format_relation_name('Blog'), 'id': str(self.other_blog.id)}
         }
@@ -54,3 +85,72 @@ def test_patch_to_one_relationship(self):
 
         response = self.client.get(url)
         assert response.data == request_data['data']
+
+    def test_patch_to_many_relationship(self):
+        url = '/blogs/{}/relationships/entry_set'.format(self.first_entry.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Entry'), 'id': str(self.first_entry.id)}, ]
+        }
+        response = self.client.patch(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 200, response.content.decode()
+
+        response = self.client.get(url)
+        assert response.data == request_data['data']
+
+    def test_post_to_one_relationship_should_fail(self):
+        url = '/entries/{}/relationships/blog'.format(self.first_entry.id)
+        request_data = {
+            'data': {'type': format_relation_name('Blog'), 'id': str(self.other_blog.id)}
+        }
+        response = self.client.post(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 405, response.content.decode()
+
+    def test_post_to_many_relationship_with_no_change(self):
+        url = '/entries/{}/relationships/comment_set'.format(self.first_entry.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Comment'), 'id': str(self.first_comment.id)}, ]
+        }
+        response = self.client.post(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 204, response.content.decode()
+
+    def test_post_to_many_relationship_with_change(self):
+        url = '/entries/{}/relationships/comment_set'.format(self.first_entry.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Comment'), 'id': str(self.second_comment.id)}, ]
+        }
+        response = self.client.post(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 200, response.content.decode()
+
+        assert request_data['data'][0] in response.data
+
+    def test_delete_to_one_relationship_should_fail(self):
+        url = '/entries/{}/relationships/blog'.format(self.first_entry.id)
+        request_data = {
+            'data': {'type': format_relation_name('Blog'), 'id': str(self.other_blog.id)}
+        }
+        response = self.client.delete(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 405, response.content.decode()
+
+    def test_delete_to_many_relationship_with_no_change(self):
+        url = '/entries/{}/relationships/comment_set'.format(self.first_entry.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Comment'), 'id': str(self.second_comment.id)}, ]
+        }
+        response = self.client.delete(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 204, response.content.decode()
+
+    def test_delete_one_to_many_relationship_with_not_null_constraint(self):
+        url = '/entries/{}/relationships/comment_set'.format(self.first_entry.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Comment'), 'id': str(self.first_comment.id)}, ]
+        }
+        response = self.client.delete(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 409, response.content.decode()
+
+    def test_delete_to_many_relationship_with_change(self):
+        url = '/authors/{}/relationships/comment_set'.format(self.author.id)
+        request_data = {
+            'data': [{'type': format_relation_name('Comment'), 'id': str(self.second_comment.id)}, ]
+        }
+        response = self.client.delete(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 200, response.content.decode()

example/urls_test.py

@@ -1,7 +1,8 @@
 from django.conf.urls import include, url
 from rest_framework import routers
 
-from example.views import BlogViewSet, EntryViewSet, AuthorViewSet, EntryRelationshipView, BlogRelationshipView
+from example.views import BlogViewSet, EntryViewSet, AuthorViewSet, EntryRelationshipView, BlogRelationshipView, \
+    CommentRelationshipView, AuthorRelationshipView
 from .api.resources.identity import Identity, GenericIdentity
 
 router = routers.DefaultRouter(trailing_slash=False)
@@ -27,5 +28,11 @@
     url(r'^blogs/(?P<pk>[^/.]+)/relationships/(?P<related_field>\w+)',
         BlogRelationshipView.as_view(),
         name='blog-relationships'),
+    url(r'^comments/(?P<pk>[^/.]+)/relationships/(?P<related_field>\w+)',
+        CommentRelationshipView.as_view(),
+        name='comment-relationships'),
+    url(r'^authors/(?P<pk>[^/.]+)/relationships/(?P<related_field>\w+)',
+        AuthorRelationshipView.as_view(),
+        name='author-relationships'),
 ]
 

example/views.py

@@ -1,29 +1,37 @@
 from rest_framework import viewsets
+
 from rest_framework_json_api.views import RelationshipView
-from example.models import Blog, Entry, Author
+from example.models import Blog, Entry, Author, Comment
 from example.serializers import BlogSerializer, EntrySerializer, AuthorSerializer
 
 
 class BlogViewSet(viewsets.ModelViewSet):
-
     queryset = Blog.objects.all()
     serializer_class = BlogSerializer
 
-class EntryViewSet(viewsets.ModelViewSet):
 
+class EntryViewSet(viewsets.ModelViewSet):
     queryset = Entry.objects.all()
     serializer_class = EntrySerializer
     resource_name = 'posts'
 
-class AuthorViewSet(viewsets.ModelViewSet):
 
+class AuthorViewSet(viewsets.ModelViewSet):
     queryset = Author.objects.all()
     serializer_class = AuthorSerializer
 
 
-
 class EntryRelationshipView(RelationshipView):
     queryset = Entry.objects
 
+
 class BlogRelationshipView(RelationshipView):
     queryset = Blog.objects
+
+
+class CommentRelationshipView(RelationshipView):
+    queryset = Comment.objects
+
+
+class AuthorRelationshipView(RelationshipView):
+    queryset = Author.objects