New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

money_manager wrapper attempt fails for managers associated on "objects" #2

Closed
wants to merge 31 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@reinbach
Contributor

reinbach commented Nov 8, 2011

after hasattr fails for _default_manager on cls, code was attempting to make use of _default_manager on the cls object.

reinbach and others added some commits Nov 8, 2011

Update the db_prep_ prototypes to work with Django 1.2+
Django 1.2 introduced multiple DB connections. And Django 1.4
removes the compatibility layer. Update our prototypes so we
work with Django 1.2+ or later.
Update version of py-moneyed required.
Actually the current development version is fine.
So that migration works, specify the default currency in text form.
It is already indicated later on but is easily missible.
Merge pull request #3 from akumria/master
Update to handle Django 1.4
Py-moneyed 0.4 has been released, so we can simplify installation eve…
…n more.

And we'll just put in references to where to get the source code for
interested parties.
Spellcheck and note South is optional.
With South installed migrations also work.
Update dependencies so installation is simpler.
The pull request, and a new release of py-moneyed has occurred.
Switch to Django 1.2+ method of specifying databases.
At least this way the tests run. Even though they do not pass yet.
Merge pull request #4 from akumria/master
Further updates and make the unittests pass
South support: Declare default attribute values.
This cleans up the generated schema migrations, and prevents errors like:
"Cannot successfully create field foo for model bar: name 'XYZ' is not defined."
Merge pull request #8 from pjdelport/master
South support: Declare default attribute values.
Allow django-money to be specified as read-only in a model
Monkey patch the Django admin so that we can display django-money fields
read-only. In order to do this, we simply catch the exception that
results from trying to convert a money object (e.g. '10 USD') into a
floating field.

And then we call just ask for the string representation of the field.
Merge pull request #9 from akumria/allow-readonly
Allow django-money to be specified as read-only in a model
Greg Reinbach Greg Reinbach
Some minor enhancements:
    Setting CURRENCIES to set the default Currency list on the admin
    Documentation about how to add a new Currency
Correctly serialize the field.
When serializing the field, we were outputing the displayed value.

This would not work, because we would (sometime) attempt to unserialize
non-UTF8 data.

Instead, just output the actual amount when serializing, since we also
have the currency to go with the amount everything Just Works (tm).
Fix AttributeError when Model inherit a manager
AttributeError: 'NoneType' object has no attribute 'get_query_set'
When a Model inherit from an Abstract one which implement a Manager.
In this case '_default_manager' is defined but equal to None
Merge pull request #11 from rach/master
Fix AttributeError when Model inherit a manager
@jakewins

This comment has been minimized.

Show comment
Hide comment
@jakewins

jakewins Oct 9, 2012

Contributor

Hey mate, the amount of work done here is awesome, and I suppose we need to figure out if it's possible to merge this back together, or what to do. It looks like you're maintaining a branch that is significantly more up to date - maybe I can give you commit rights to this repo (or add a link to your fork), and you can take over maintaining it?

Either way, the amount of commits here is way too much for me to merge safely, it will need to be done in some other way, for instance by merging the current state of this repo over to you and then deprecating this repo, if you want to take over maintaining it.

Closing this PR, but let me know what you think about taking over the project :)

Contributor

jakewins commented Oct 9, 2012

Hey mate, the amount of work done here is awesome, and I suppose we need to figure out if it's possible to merge this back together, or what to do. It looks like you're maintaining a branch that is significantly more up to date - maybe I can give you commit rights to this repo (or add a link to your fork), and you can take over maintaining it?

Either way, the amount of commits here is way too much for me to merge safely, it will need to be done in some other way, for instance by merging the current state of this repo over to you and then deprecating this repo, if you want to take over maintaining it.

Closing this PR, but let me know what you think about taking over the project :)

@jakewins jakewins closed this Oct 9, 2012

benjaoming pushed a commit that referenced this pull request Nov 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment