money_manager wrapper attempt fails for managers associated on "objects" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here you go.
Django 1.2 introduced multiple DB connections. And Django 1.4 removes the compatibility layer. Update our prototypes so we work with Django 1.2+ or later.
Actually the current development version is fine.
It is already indicated later on but is easily missible.
Update to handle Django 1.4
…n more. And we'll just put in references to where to get the source code for interested parties.
With South installed migrations also work.
The pull request, and a new release of py-moneyed has occurred.
At least this way the tests run. Even though they do not pass yet.
Found by the unittests.
Further updates and make the unittests pass
added MANIFEST
This cleans up the generated schema migrations, and prevents errors like: "Cannot successfully create field foo for model bar: name 'XYZ' is not defined."
South support: Declare default attribute values.
Monkey patch the Django admin so that we can display django-money fields read-only. In order to do this, we simply catch the exception that results from trying to convert a money object (e.g. '10 USD') into a floating field. And then we call just ask for the string representation of the field.
Allow django-money to be specified as read-only in a model
Setting CURRENCIES to set the default Currency list on the admin
Documentation about how to add a new Currency
When serializing the field, we were outputing the displayed value. This would not work, because we would (sometime) attempt to unserialize non-UTF8 data. Instead, just output the actual amount when serializing, since we also have the currency to go with the amount everything Just Works (tm).
Serialize properly
AttributeError: 'NoneType' object has no attribute 'get_query_set' When a Model inherit from an Abstract one which implement a Manager. In this case '_default_manager' is defined but equal to None
Fix AttributeError when Model inherit a manager
|
Hey mate, the amount of work done here is awesome, and I suppose we need to figure out if it's possible to merge this back together, or what to do. It looks like you're maintaining a branch that is significantly more up to date - maybe I can give you commit rights to this repo (or add a link to your fork), and you can take over maintaining it? Either way, the amount of commits here is way too much for me to merge safely, it will need to be done in some other way, for instance by merging the current state of this repo over to you and then deprecating this repo, if you want to take over maintaining it. Closing this PR, but let me know what you think about taking over the project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after hasattr fails for _default_manager on cls, code was attempting to make use of _default_manager on the cls object.