From f9f5117cba41224725c36038033d857b55712637 Mon Sep 17 00:00:00 2001 From: Maik Hoepfel Date: Fri, 7 Jun 2013 12:01:03 +0100 Subject: [PATCH] Default value for HTTP_REFERER in BulkEditMixin Avoids a key error when a referer is not available. Also removed BulkEditMixin from the PartnerListView as it was not used. --- oscar/apps/dashboard/partners/views.py | 3 +-- oscar/views/generic.py | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/oscar/apps/dashboard/partners/views.py b/oscar/apps/dashboard/partners/views.py index 5278656e990..25b9562cce4 100644 --- a/oscar/apps/dashboard/partners/views.py +++ b/oscar/apps/dashboard/partners/views.py @@ -10,14 +10,13 @@ from oscar.apps.dashboard.partners.forms import UserEmailForm, ExistingUserForm, NewUserForm from oscar.core.loading import get_classes -from oscar.views.generic import BulkEditMixin Partner = get_model('partner', 'Partner') PartnerSearchForm, PartnerCreateForm = get_classes( 'dashboard.partners.forms', ['PartnerSearchForm', 'PartnerCreateForm']) -class PartnerListView(generic.ListView, BulkEditMixin): +class PartnerListView(generic.ListView): model = Partner context_object_name = 'partners' template_name = 'dashboard/partners/partner_list.html' diff --git a/oscar/views/generic.py b/oscar/views/generic.py index fdb70f40ebc..99fdab69d33 100644 --- a/oscar/views/generic.py +++ b/oscar/views/generic.py @@ -52,10 +52,10 @@ def get_queryset(self): pass def get_error_url(self, request): - return request.META['HTTP_REFERER'] + return request.META.get('HTTP_REFERER', '.') def get_success_url(self, request): - return request.META['HTTP_REFERER'] + return request.META('HTTP_REFERER', '.') def post(self, request, *args, **kwargs): # Dynamic dispatch pattern - we forward POST requests onto a method