fix oscar_populate_countries with current pycountry #2182

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@RaphaelKimmig

pycountry has changed the format of the alpha* attributes[0], thus
breaking oscar_populate_countries. This commit updates the
oscar_populate_countries management command to work with current
versions of pycountry.

[0] https://bitbucket.org/flyingcircus/pycountry/src/06ef9e89c25d7d9286a5ac9da150f832ed4cb02f/HISTORY.txt?at=default&fileviewer=file-view-default#HISTORY.txt-102

fix oscar_populate_countries with current pycountry
pycountry has changed the format of the alpha* attributes[0], thus
breaking oscar_populate_countries. This commit updates the
oscar_populate_countries management command to work with current
versions of pycountry.

[0] https://bitbucket.org/flyingcircus/pycountry/src/06ef9e89c25d7d9286a5ac9da150f832ed4cb02f/HISTORY.txt?at=default&fileviewer=file-view-default#HISTORY.txt-102
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 5, 2016

Current coverage is 84.24% (diff: 100%)

Merging #2182 into master will not change coverage

@@             master      #2182   diff @@
==========================================
  Files           304        304          
  Lines         15091      15091          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          12713      12713          
  Misses         2378       2378          
  Partials          0          0          

Powered by Codecov. Last update b161403...7912b18

codecov-io commented Dec 5, 2016

Current coverage is 84.24% (diff: 100%)

Merging #2182 into master will not change coverage

@@             master      #2182   diff @@
==========================================
  Files           304        304          
  Lines         15091      15091          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          12713      12713          
  Misses         2378       2378          
  Partials          0          0          

Powered by Codecov. Last update b161403...7912b18

@eve1234

This comment has been minimized.

Show comment
Hide comment
@eve1234

eve1234 Dec 6, 2016

Hello,

Do I uninstall and install django-oscar again? In order for the above changes to work for me? And which version of django-oscar should be installed?

pip install django-oscar-1.3.0?

Regards

eve1234 commented Dec 6, 2016

Hello,

Do I uninstall and install django-oscar again? In order for the above changes to work for me? And which version of django-oscar should be installed?

pip install django-oscar-1.3.0?

Regards

@mvantellingen

This comment has been minimized.

Show comment
Hide comment
@mvantellingen

mvantellingen Feb 4, 2017

Member

Thanks, fixed via fd02f7c

Member

mvantellingen commented Feb 4, 2017

Thanks, fixed via fd02f7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment