New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document test setup. #2569

Merged
merged 2 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@khink
Contributor

khink commented Jan 17, 2018

Document how to setup a virtualenv for running test, for dummies.

@@ -7,6 +7,8 @@ Running tests
Oscar uses pytest_ to run the tests, which can be invoked using::
$ mkvirtualenv oscar-tests
$ pip install -e .[test]

This comment has been minimized.

@sasha0

sasha0 Jan 17, 2018

Member

I think we should add a sentence, saying that next commands allows to create virtual environment and install dependencies in order to run tests.

@khink khink force-pushed the fourdigits:document-test-setup branch from 621f7cb to 4b52a8f Jan 17, 2018

@khink

This comment has been minimized.

Contributor

khink commented Jan 17, 2018

There seems to be more, i get test failures: https://gist.github.com/khink/0973018b149d3a985393d9d43a5ae291

@khink

This comment has been minimized.

Contributor

khink commented Jan 17, 2018

Looks like it does work with python2.7. I used python3.4 (3.4.7 actually), will try with 3.6 and update.

@khink khink force-pushed the fourdigits:document-test-setup branch from 4b52a8f to 8fab92f Jan 17, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 17, 2018

Codecov Report

Merging #2569 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2569   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         311      311           
  Lines       15298    15298           
=======================================
  Hits        12771    12771           
  Misses       2527     2527
@khink

This comment has been minimized.

Contributor

khink commented Jan 17, 2018

I see a "bad magic number" which suggests i should throw away .pyc files. That fixed it, indeed.

I'm ready to start writing tests now, and i hope this addition will help others getting started more quickly.

@sasha0 sasha0 added the ✎ Docs label Jan 17, 2018

@sasha0 sasha0 merged commit 760b386 into django-oscar:master Jan 17, 2018

0 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sasha0

This comment has been minimized.

Member

sasha0 commented Jan 17, 2018

Good good.

Thanks for the contribution!

@khink

This comment has been minimized.

Contributor

khink commented Jan 17, 2018

Thanks for your speedy response, and your help!

@sasha0

This comment has been minimized.

Member

sasha0 commented Jan 17, 2018

Np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment