Django 1.8 compatibility #1263
Django 1.8 compatibility #1263
Conversation
| return getattr(meta, 'model_name', meta.module_name) | ||
|
|
||
| # commit_on_success replaced by atomic in Django >=1.8 | ||
| atomic_decorator = getattr(django.db.transaction, 'atomic', django.db.transaction.commit_on_success) |
There was a problem hiding this comment.
If you look in the Travis output, this line causes an error on Django 1.8. This is because the third parameter to getattr() is evaluated whether 'atomic' is found or not, and django.db.transaction.commit_on_success doesn't exist in 1.8.
Perhaps:
atomic_decorator = getattr(django.db.transaction, 'atomic') or getattr(django.db.transaction, 'commit_on_success')
|
@georgedorn thanks, fixed |
|
We still have failures under Django 1.8. (https://travis-ci.org/toastdriven/django-tastypie/builds/44896068). Travis is currently ignoring those as allowed failures. @toastdriven: I think this is something only you can fix; it's also set to ignore failures for Django 1.7, which is bad. So this PR fixes the |
transaction.commit_on_successandOptions.module_nameare deprecated in Django 1.7 and will be removed in 1.8