Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ToManyField.dehydrate with a null value regression. #1544

Merged
merged 2 commits into from Apr 9, 2018

Conversation

@georgedorn
Copy link
Contributor

georgedorn commented Mar 19, 2018

Probably fixes #1537 but the full extent of that issue remains unclear. I'd like to add a test for a proper request/response (rather than the extremely simplified test of dehydrate()) but I am waiting for enough information in that ticket to reproduce the bug in a real-world situation.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage increased (+0.03%) to 95.059% when pulling 119278e on fix/none_m2m_typeerror into 9879a84 on master.

@georgedorn georgedorn changed the title Fix for #1537 with test Fix for ToManyField.dehydrate with a null value regression. Apr 9, 2018
@georgedorn georgedorn merged commit c8d6d07 into master Apr 9, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 95.059%
Details
@georgedorn georgedorn deleted the fix/none_m2m_typeerror branch Apr 9, 2018
saedmansour added a commit to segmanta/django-tastypie that referenced this pull request Dec 19, 2019
…astypie#1544)

* Fix for django-tastypie#1537 with test

* Add test ensuring a bad attribute name raises an exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.