Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Fix' for upstream regression regarding non-string query params in tests #1565

Merged
merged 1 commit into from Aug 13, 2018

Conversation

@georgedorn
Copy link
Contributor

georgedorn commented Aug 13, 2018

As noted in the target branch:

This test is failing:
FAIL: test_multiple (core.tests.paginator.PaginatorTestCase)

This is due to a regression in django 2.1. There's a fix here but it hasn't been released yet:
django/django@d8e2be4

Note that it says "due to lazily-written tests" and I generally agree; QueryDict when populated from an actual HTTP request will always be strings, not ints, and our tests should be written to reflect that.

@georgedorn georgedorn merged commit 788d26a into django-2.1 Aug 13, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
georgedorn added a commit that referenced this pull request Aug 28, 2018
* Django 2.1: Set up test matrix

* Django 2.1: fix missing QUERY_TERMS (#1564)

* Isolate failing assertion in separate test

* query_terms: try interrogating the django field directly

* Replace class_lookups with get_lookups() which is a more complete list

* Leftover debug

* Django 2.1: 'Fix' for upstream regression regarding non-string query params in tests (#1565)

* Django 2.1: explicitly set blank=True on BooleanFields due to upstream regression (#1567)

Failing tests unrelated to this PR; those will need another compat shim (and pep8).

* Fix/django2.1 cleanups (#1568)

* Fix pep8

* Remove tests for Django 1.8

* More 1.8 removal, stop installing django 2 on python 2

* More dependency fixes

* Explicitly run doctests for validate_jsonp module, to bump coverage

* flake8
saedmansour added a commit to segmanta/django-tastypie that referenced this pull request Dec 19, 2019
* Django 2.1: Set up test matrix

* Django 2.1: fix missing QUERY_TERMS (django-tastypie#1564)

* Isolate failing assertion in separate test

* query_terms: try interrogating the django field directly

* Replace class_lookups with get_lookups() which is a more complete list

* Leftover debug

* Django 2.1: 'Fix' for upstream regression regarding non-string query params in tests (django-tastypie#1565)

* Django 2.1: explicitly set blank=True on BooleanFields due to upstream regression (django-tastypie#1567)

Failing tests unrelated to this PR; those will need another compat shim (and pep8).

* Fix/django2.1 cleanups (django-tastypie#1568)

* Fix pep8

* Remove tests for Django 1.8

* More 1.8 removal, stop installing django 2 on python 2

* More dependency fixes

* Explicitly run doctests for validate_jsonp module, to bump coverage

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.